From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756502AbZCXLAH (ORCPT ); Tue, 24 Mar 2009 07:00:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753201AbZCXK7y (ORCPT ); Tue, 24 Mar 2009 06:59:54 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:44126 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753148AbZCXK7y (ORCPT ); Tue, 24 Mar 2009 06:59:54 -0400 From: Alan Cox Subject: [PATCH] pluto2: silence spew of card hung up messages To: video4linux-list@redhat.com, linux-kernel@vger.kernel.org Date: Tue, 24 Mar 2009 11:00:39 +0000 Message-ID: <20090324105251.9763.24193.stgit@localhost.localdomain> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the card is ejected on some systems you get a spew of messages as other shared IRQ devices interrupt between the card eject and the card IRQ disable. We don't need to spew them all out Closes #7472 Signed-off-by: Alan Cox --- drivers/media/dvb/pluto2/pluto2.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb/pluto2/pluto2.c b/drivers/media/dvb/pluto2/pluto2.c index d101b30..ee89623 100644 --- a/drivers/media/dvb/pluto2/pluto2.c +++ b/drivers/media/dvb/pluto2/pluto2.c @@ -116,6 +116,7 @@ struct pluto { /* irq */ unsigned int overflow; + unsigned int dead; /* dma */ dma_addr_t dma_addr; @@ -336,8 +337,10 @@ static irqreturn_t pluto_irq(int irq, void *dev_id) return IRQ_NONE; if (tscr == 0xffffffff) { - // FIXME: maybe recover somehow - dev_err(&pluto->pdev->dev, "card hung up :(\n"); + if (pluto->dead == 0) + dev_err(&pluto->pdev->dev, "card has hung or been ejected.\n"); + /* It's dead Jim */ + pluto->dead = 1; return IRQ_HANDLED; }