Re: [PATCH 2/2] fs: don't include <linux/gfp.h> to fix headers-export-check

[Ingo Molnar <mingo@elte.hu>]

* Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> On Tue, 2009-03-24 at 14:12 +0100, Arnd Bergmann wrote:
> > On Tuesday 24 March 2009, Pekka Enberg wrote:
> > >    
> > > From: Pekka Enberg <penberg@cs.helsinki.fi>
> > > 
> > > Impact: fix build
> > > 
> > > This patch fixes a headers-export-check failure:
> > > 
> > >   /home/mingo/tip/usr/include/linux/bsg.h:11: found __[us]{8,16,32,64} type without #include <linux/types.h>
> > >   /home/mingo/tip/usr/include/linux/fs.h:11: included file 'linux/gfp.h' is not exported
> > >   make[3]: *** [/home/mingo/tip/usr/include/linux/.check] Error 1
> > >   make[2]: *** [linux] Error 2
> > > 
> > > Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
> > > Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
> > > ---
> > >  include/linux/fs.h |   16 ++++++----------
> > >  1 files changed, 6 insertions(+), 10 deletions(-)
> > > 
> > > diff --git a/include/linux/fs.h b/include/linux/fs.h
> > > index add95da..11fdc57 100644
> > > --- a/include/linux/fs.h
> > > +++ b/include/linux/fs.h
> > > @@ -8,7 +8,6 @@
> > >  
> > >  #include <linux/limits.h>
> > >  #include <linux/ioctl.h>
> > > -#include <linux/gfp.h>
> > >  
> > >  /*
> > 
> > I think a cleaner fix would be to move the include of gfp.h into the
> > second #include block that is part of #ifdef __KERNEL__, as is the
> > only user of get_zeroed_page in there.
> 
> Alexey suggested putting the functions in security.h instead which 
> is even better. I'll submit that formally as soon as I have the 
> chance to test it.

yep. Hopefully it wont have ripple effects. The whole house of cards 
called include/linux/*.h seems to be imploding ;-)

	Ingo