mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Domsch <Matt_Domsch@dell.com>
To: Corey Minyard <minyard@acm.org>
Cc: Martin Wilck <martin.wilck@fujitsu-siemens.com>,
	Greg KH <greg@kroah.com>,
	"openipmi-developer@lists.sourceforge.net" 
	<openipmi-developer@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Openipmi-developer] Improving IPMI performance under load
Date: Tue, 24 Mar 2009 10:50:35 -0500	[thread overview]
Message-ID: <20090324155035.GB16332@auslistsprd01.us.dell.com> (raw)
In-Reply-To: <49C8DB54.4010200@acm.org>

On Tue, Mar 24, 2009 at 08:08:36AM -0500, Corey Minyard wrote:
> Martin Wilck wrote:
> >Hi Corey,
> >
> >yesterday I posted some results about the IPMI performance under CPU 
> >load, which can be up to 25 times slower than in an idle system. I think 
> >it might be worthwhile to try to improve that behavior as well.
> >  
> Yes, that would be expected, as kipmid would never be scheduled in a 
> busy system, and it would just be the timer driving things.
> 
> >I made a variation of my patch which introduces a second parameter 
> >(kipmid_min_busy) that causes kipmid not to call schedule() for a 
> >certain amount of time. Thus if there's IPMI traffic pending, kipmid 
> >will busy-loop for kipmid_min_busy seconds, then starting to schedule() 
> >in each loop as it does now, and finally go to sleep when 
> >kipmid_max_busy is reached. At the same time, I changed the nice value 
> >of kipmid from 19 to 0.
> >  
> I would guess that changing the nice value is the main thing that caused 
> the difference.  The other changes probably didn't make as big a difference.
> 
> >With this patch and e.g. min_busy=100 and max_busy=200, there is no 
> >noticeable difference any more between IPMI performance with and without 
> >CPU load.
> >
> >The patch + results still need cleanup, therefore I am not sending it 
> >right now. Just wanted to hear what you think.
> >  
> I'm ok with tuning like this, but most users are probably not going to 
> want this type of behavior.

I still get complaints from users who see their CPU utilization spike
attributed to kipmi0 when userspace throws a lot of requests down to
the controller.  I've seen them want to limit kipmi0 even further, not
speed it up.

-- 
Matt Domsch
Linux Technology Strategist, Dell Office of the CTO
linux.dell.com & www.dell.com/linux

  parent reply	other threads:[~2009-03-24 15:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-19 16:27 [PATCH] limit CPU time spent in kipmid Martin Wilck
2009-03-19 21:31 ` Corey Minyard
2009-03-19 23:51   ` Greg KH
2009-03-20 15:30     ` Corey Minyard
2009-03-20 17:47       ` Greg KH
2009-03-20 18:28         ` Corey Minyard
2009-03-23 13:17           ` [PATCH] limit CPU time spent in kipmid (PREVIOUS WAS BROKEN) Martin Wilck
2009-03-23 15:32             ` Greg KH
2009-03-23 16:20               ` Martin Wilck
2009-03-23 20:39             ` Corey Minyard
2009-03-24  9:22               ` Martin Wilck
2009-03-24  9:30               ` Improving IPMI performance under load Martin Wilck
2009-03-24 13:08                 ` [Openipmi-developer] " Corey Minyard
2009-03-24 13:21                   ` Martin Wilck
2009-03-24 15:50                   ` Matt Domsch [this message]
2009-03-24 17:15                     ` Martin Wilck
2009-04-06 13:48               ` [PATCH] limit CPU time spent in kipmid (PREVIOUS WAS BROKEN) Martin Wilck
2009-06-04 18:39                 ` [PATCH] limit CPU time spent in kipmid (version 4) Martin Wilck
2009-03-23 13:25           ` [PATCH] limit CPU time spent in kipmid Martin Wilck
2009-03-19 22:41 ` [Openipmi-developer] " Bela Lubkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090324155035.GB16332@auslistsprd01.us.dell.com \
    --to=matt_domsch@dell.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.wilck@fujitsu-siemens.com \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®