From: Wim Van Sebroeck <wim@iguana.be>
To: stoyboyker@gmail.com
Cc: linux-kernel@vger.kernel.org, wim@iguana.be
Subject: Re: [PATCH 08/13] [watchdog] changed ioctls to unlocked
Date: Wed, 25 Mar 2009 09:11:51 +0100 [thread overview]
Message-ID: <20090325081151.GD27002@infomag.iguana.be> (raw)
In-Reply-To: <1237929168-15341-9-git-send-email-stoyboyker@gmail.com>
Hi Stoyan,
> From: Stoyan Gaydarov <stoyboyker@gmail.com>
>
> Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com>
> ---
> drivers/watchdog/riowd.c | 37 +++++++++++++++++++++++++++----------
> 1 files changed, 27 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/watchdog/riowd.c b/drivers/watchdog/riowd.c
> index 09cb183..44058c1 100644
> --- a/drivers/watchdog/riowd.c
> +++ b/drivers/watchdog/riowd.c
> @@ -86,9 +86,10 @@ static int riowd_release(struct inode *inode, struct file *filp)
> return 0;
> }
>
> -static int riowd_ioctl(struct inode *inode, struct file *filp,
> - unsigned int cmd, unsigned long arg)
> +static long riowd_ioctl(struct file *filp, unsigned int cmd,
> + unsigned long arg)
> {
> + lock_kernel();
NAK. See commit c2dc3084010a7996c34e84bea14ff5346af7abd7 in the linux-2.6-watchdog-next tree that allready fixes this (and that will go to Linus one of these days for inclusion).
Kind regards,
Wim.
prev parent reply other threads:[~2009-03-25 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 21:12 stoyboyker
2009-03-25 8:11 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325081151.GD27002@infomag.iguana.be \
--to=wim@iguana.be \
--cc=linux-kernel@vger.kernel.org \
--cc=stoyboyker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®