mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: stoyboyker@gmail.com
Cc: linux-kernel@vger.kernel.org,
	Stoyan Gaydarov <stoyboyker@gmail.com>,
	schwidefsky@de.ibm.com, linux-s390@vger.kernel.org
Subject: Re: [PATCH 05/13] [s390] changed ioctls to unlocked
Date: Wed, 25 Mar 2009 12:58:45 +0100	[thread overview]
Message-ID: <20090325125845.2923921b@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <1237929168-15341-6-git-send-email-stoyboyker@gmail.com>

On Tue, 24 Mar 2009 16:12:40 -0500
stoyboyker@gmail.com wrote:

> From: Stoyan Gaydarov <stoyboyker@gmail.com>
> 
> Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com>
> ---
>  drivers/s390/char/tape_char.c  |   47 +++++++++++++++++++++++----------
>  drivers/s390/char/vmwatchdog.c |   57 ++++++++++++++++++++++++++--------------
>  2 files changed, 70 insertions(+), 34 deletions(-)

Please resend with the comments that Jonathan made for your other
patches: first define variables then lock_kernel() and also please use
gotos.

Thanks!

      reply	other threads:[~2009-03-25 11:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-24 21:12 stoyboyker
2009-03-25 11:58 ` Heiko Carstens [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090325125845.2923921b@osiris.boeblingen.de.ibm.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=stoyboyker@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®