From: David Miller <davem@davemloft.net>
To: rdreier@cisco.com
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: RDMA/nes: Fix mis-merge
Date: Thu, 26 Mar 2009 16:31:14 -0700 (PDT) [thread overview]
Message-ID: <20090326.163114.131582923.davem@davemloft.net> (raw)
In-Reply-To: <adahc1fuarm.fsf_-_@cisco.com>
From: Roland Dreier <rdreier@cisco.com>
Date: Thu, 26 Mar 2009 16:25:49 -0700
> When net-next and infiniband were merged upstream, each branch deleted
> one of a pair of adjacent lines from nes_nic.c, but when Linus fixed the
> conflict up, he brought back both of the lines. Fix up to the intended
> final tree state.
> ---
> > Well, I merged infiniband, and that caused more conflicts. I fixed them
> > up, but people need to double-check my fixes.
>
> Looks like you mismerged one file -- each side deleted one line right
> next to each other, but your merge left both lines in. I think the
> patch below is needed. (The cxgb3 fix looks correct)
>
> drivers/infiniband/hw/nes/nes_nic.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
Looks good, Linus please apply:
Acked-by: David S. Miller <davem@davemloft.net>
> diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c
> index 8d3e4c6..ecb1f6f 100644
> --- a/drivers/infiniband/hw/nes/nes_nic.c
> +++ b/drivers/infiniband/hw/nes/nes_nic.c
> @@ -1602,8 +1602,6 @@ struct net_device *nes_netdev_init(struct nes_device *nesdev,
> netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, 128);
> nes_debug(NES_DBG_INIT, "Enabling VLAN Insert/Delete.\n");
> netdev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
> - netdev->vlan_rx_register = nes_netdev_vlan_rx_register;
> - netdev->features |= NETIF_F_LLTX;
>
> /* Fill in the port structure */
> nesvnic->netdev = netdev;
next prev parent reply other threads:[~2009-03-26 23:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 9:07 [GIT]: Networking for 2.6.30 David Miller
2009-03-26 9:41 ` Lorenzo Allegrucci
2009-03-26 22:25 ` David Miller
2009-03-26 22:56 ` Linus Torvalds
2009-03-26 23:00 ` David Miller
2009-03-26 23:25 ` RDMA/nes: Fix mis-merge Roland Dreier
2009-03-26 23:31 ` David Miller [this message]
2009-03-26 23:38 ` Linus Torvalds
2009-03-26 23:41 ` Linus Torvalds
2009-03-26 23:53 ` Roland Dreier
2009-03-27 7:29 ` David Miller
2009-03-26 23:48 ` Roland Dreier
2009-03-27 19:16 ` [PATCH] " Roland Dreier
2009-03-27 21:41 ` Linus Torvalds
2009-03-27 22:15 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090326.163114.131582923.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®