mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: James Morris <jmorris@namei.org>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	linux-security-module@vger.kernel.org, Greg KH <greg@kroah.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: TOMOYO in linux-next
Date: Fri, 27 Mar 2009 01:36:20 +0100	[thread overview]
Message-ID: <20090327003620.GI29836@elf.ucw.cz> (raw)
In-Reply-To: <alpine.LRH.2.00.0903271102240.7492@tundra.namei.org>

Hi!

> As for the rest of the feedback, please work with the developers to fix 
> any bugs or lack of documentation.

Apparently not even its user<->kernel interface was reviewed. This
violates "one value per file in sysfs":

    [root@tomoyo]# cat /sys/kernel/security/tomoyo/meminfo
    Shared:       61440
    Private:      69632
    Dynamic:        768
    Total:       131840
    
    You can set memory quota by writing to this file.
    (Example)
    [root@tomoyo]# echo Shared: 2097152 > /sys/kernel/security/tomoyo/meminfo
    [root@tomoyo]# echo Private: 2097152 > /sys/kernel/security/tomoyo/meminfo

(not to mention being ugly as hell).

This is totaly useless once tomoyo is merged:

    ** /sys/kernel/security/tomoyo/version **
    
    This file is used for getting TOMOYO Linux's version.
    (Example)
    [root@etch]# cat /sys/kernel/security/tomoyo/version
    2.2.0-pre


									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2009-03-27  0:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-26 21:50 Pavel Machek
2009-03-27  0:15 ` James Morris
2009-03-27  0:30   ` Pavel Machek
2009-03-27  0:51     ` James Morris
2009-03-27 11:36       ` Pavel Machek
2009-03-27  0:36   ` Pavel Machek [this message]
2009-03-27  0:46     ` James Morris
2009-03-27 11:35       ` Pavel Machek
2009-03-27  4:12   ` Tetsuo Handa
2009-03-27  8:04     ` James Morris
2009-03-27 11:40     ` Pavel Machek
2009-03-27 11:41     ` private user<->kernel interface in linux-2.6.30, was " Pavel Machek
2009-04-06 11:49     ` Tetsuo Handa
2009-04-06 12:01       ` Pavel Machek
2009-04-06 22:21       ` James Morris
     [not found] <ck5CF-5mU-11@gated-at.bofh.it>
2009-03-27  9:28 ` Bodo Eggert
2009-03-27 11:42   ` Pavel Machek
2009-03-27 13:04     ` Bodo Eggert
2009-03-29 11:58       ` Pavel Machek
2009-03-29 14:25         ` Bodo Eggert
2009-03-29 21:39           ` Pavel Machek
2009-03-30 11:22             ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090327003620.GI29836@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=greg@kroah.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®