From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: davem@davemloft.net
Subject: Re: netrom: zero length frame filtering in NetRom
Date: Fri, 27 Mar 2009 10:28:23 +0000 [thread overview]
Message-ID: <20090327102823.3c485bfc@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200903270102.n2R12S2U021576@hera.kernel.org>
> + /* NetRom empty data frame has no meaning : ignore it */
> + if (copied == 0) {
> + goto out;
> + }
> +
Also broken - and doesn't follow the coding style either 8)
I'm not familiar enough with ROSE to tell if the ROSE one is wrong, but
rose is X.25 LL based (sadly without the X.29 layer) so it seems odd
there too (especially for datagram services)
next parent reply other threads:[~2009-03-27 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200903270102.n2R12S2U021576@hera.kernel.org>
2009-03-27 10:28 ` Alan Cox [this message]
2009-03-27 21:34 ` David Miller
2009-03-27 22:14 ` David Miller
2009-03-28 0:21 ` Alan Cox
2009-03-28 0:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327102823.3c485bfc@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®