From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757665AbZC0QRu (ORCPT ); Fri, 27 Mar 2009 12:17:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756685AbZC0QRi (ORCPT ); Fri, 27 Mar 2009 12:17:38 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:41254 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755230AbZC0QRh convert rfc822-to-8bit (ORCPT ); Fri, 27 Mar 2009 12:17:37 -0400 Date: Fri, 27 Mar 2009 13:17:29 -0300 From: Mauro Carvalho Chehab To: =?ISO-8859-1?B?TultZXRoIE3hcnRvbg==?= Cc: linux-media@vger.kernel.org, LKML Subject: Re: [PATCH] v4l2: fill reserved fields of VIDIOC_ENUMAUDIO also Message-ID: <20090327131729.0842bdec@pedra.chehab.org> In-Reply-To: <49CA611B.5050902@freemail.hu> References: <49CA611B.5050902@freemail.hu> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.10.4; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Mar 2009 17:51:39 +0100 Németh Márton wrote: > From: Márton Németh > > When enumerating audio inputs with VIDIOC_ENUMAUDIO the gspca_sunplus driver > does not fill the reserved fields of the struct v4l2_audio with zeros as > required by V4L2 API revision 0.24 [1]. Add the missing initializations to > the V4L2 framework. > > The patch was tested with v4l-test 0.10 [2] with gspca_sunplus driver and > with Trust 610 LCD POWERC@M ZOOM webcam. It didn't apply against the development tree. Anyway, a recent patch removed the need of memset there. the memory fill with zero now happens at the same code we copy the structure values. Cheers, Mauro