From: Jan Kara <jack@suse.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: tytso@mit.edu, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PULL REQUEST] Quota changes for 2.6.30
Date: Fri, 27 Mar 2009 23:52:43 +0100 [thread overview]
Message-ID: <20090327225243.GK31071@duck.suse.cz> (raw)
In-Reply-To: <alpine.LFD.2.00.0903271448520.3994@localhost.localdomain>
On Fri 27-03-09 14:52:11, Linus Torvalds wrote:
> On Fri, 27 Mar 2009, Jan Kara wrote:
> > On Thu 26-03-09 16:16:47, Linus Torvalds wrote:
> > >
> > >
> > > On Thu, 26 Mar 2009, Jan Kara wrote:
> > > >
> > > > could you please pull from
> > > >
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-quota-2.6.git for_linus
> > >
> > > "Already up-to-date."
> > >
> > > Forgot to actually push it out?
> > Damn, you're right. Should be there now.
>
> It is, but now when I pull I notice that you hadn't used "-M --summary"
> when asking me to pull. You claimed:
>
> 66 files changed, 4770 insertions(+), 4565 deletions(-)
>
> but in fact it's really:
>
> 58 files changed, 902 insertions(+), 697 deletions(-)
> create mode 100644 fs/quota/Kconfig
> create mode 100644 fs/quota/Makefile
> rename fs/{ => quota}/dquot.c (85%)
> rename fs/{ => quota}/quota.c (94%)
> rename fs/{ => quota}/quota_tree.c (84%)
> rename fs/{ => quota}/quota_tree.h (100%)
> rename fs/{ => quota}/quota_v1.c (79%)
> rename fs/{ => quota}/quota_v2.c (98%)
> rename fs/{ => quota}/quotaio_v1.h (100%)
> rename fs/{ => quota}/quotaio_v2.h (100%)
>
> so please do change your pull-request script to add -M (for rename
> detection) and --summary (for that "new, deleted and renamed files"
> summary at the end).
OK, I didn't know this is the preferred way. Will do next time.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2009-03-27 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 1:22 Jan Kara
2009-03-26 23:16 ` Linus Torvalds
2009-03-27 20:12 ` Jan Kara
2009-03-27 21:52 ` Linus Torvalds
2009-03-27 22:52 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327225243.GK31071@duck.suse.cz \
--to=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®