From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Chris Mason <chris.mason@oracle.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix __ucmpdi2 compile bug on 32 bit builds
Date: Sat, 28 Mar 2009 01:16:26 +1100 [thread overview]
Message-ID: <20090328011626.5d6f94f4.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20090327134252.0f24773b@osiris.boeblingen.de.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
Hi Heiko,
On Fri, 27 Mar 2009 13:42:52 +0100 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
>
\> @@ -2884,25 +2884,19 @@ int extent_fiemap(struct inode *inode, s
> disko = 0;
> flags = 0;
>
> - switch (em->block_start) {
> - case EXTENT_MAP_LAST_BYTE:
> + if (em->block_start == EXTENT_MAP_LAST_BYTE) {
I might be a good idea to put a comment there about why this isn't a
switch statement so that someone doesn't "clean up" this code in the
future.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-03-27 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 12:42 Heiko Carstens
2009-03-27 14:16 ` Stephen Rothwell [this message]
2009-03-27 14:24 ` Kyle McMartin
2009-03-27 14:37 ` Chris Mason
2009-03-28 9:38 ` Andi Kleen
2009-03-29 19:22 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090328011626.5d6f94f4.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=chris.mason@oracle.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®