From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Erik Waling <erik.waling@konftel.se>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] macb: RLE and BNA handling
Date: Mon, 30 Mar 2009 14:04:56 +0200 [thread overview]
Message-ID: <20090330140456.07eb48b8@hskinnemoen-d830> (raw)
In-Reply-To: <1238060296.23641.8.camel@konftel>
Erik Waling wrote:
> Have you had the time to check the patch below? These two issues still
> needs to be addressed.
Yeah...sorry for not responding earlier.
> If you are unsure of the BNA part you could at least pass the RLE part
> upstreams since it happens more frequently.
Right. I have to admit I'm not at all convinced about the BNA part...it
seems to me like the only scenario when it makes a difference is when
the ring is so small that it can't hold an entire frame. And if that's
the case, isn't the easiest solution to just increase the size of the
ring?
So, could you please split the patch up into the following parts:
1. TX RLE handling
2. Call macb_rx() regardless of the status
3. Handle incomplete RX frames
4. Special case for RX BNA
Then I can pass on the first three, and we can keep discussing the last
one, which is the one I'm not sure about.
Haavard
next prev parent reply other threads:[~2009-03-30 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 16:21 Erik Waling
2009-01-14 7:47 ` Erik Waling
2009-01-14 10:15 ` Haavard Skinnemoen
2009-01-14 10:27 ` Erik Waling
2009-01-14 12:03 ` Haavard Skinnemoen
2009-01-15 13:37 ` Erik Waling
2009-03-26 9:38 ` Erik Waling
2009-03-30 12:04 ` Haavard Skinnemoen [this message]
2009-03-31 14:50 ` Erik Waling
2009-04-01 9:31 ` Haavard Skinnemoen
2009-04-01 13:05 ` Erik Waling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090330140456.07eb48b8@hskinnemoen-d830 \
--to=haavard.skinnemoen@atmel.com \
--cc=erik.waling@konftel.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®