From: Oleg Nesterov <oleg@redhat.com>
To: Chris Wright <chrisw@sous-sol.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Peter Lojkin <ia6432@inbox.ru>,
linux-kernel@vger.kernel.org, Roland McGrath <roland@redhat.com>,
stable@kernel.org
Subject: Re: [stable] [PATCH 1/2] posix-timers: fix RLIMIT_CPU && fork()
Date: Tue, 31 Mar 2009 16:57:50 +0200 [thread overview]
Message-ID: <20090331145750.GB4792@redhat.com> (raw)
In-Reply-To: <20090331030133.GH3264@hera.kernel.org>
On 03/31, Chris Wright wrote:
>
> * Oleg Nesterov (oleg@redhat.com) wrote:
> > See http://bugzilla.kernel.org/show_bug.cgi?id=12911
> >
> > copy_signal() copies signal->rlim, but RLIMIT_CPU is "lost". Because
> > posix_cpu_timers_init_group() sets cputime_expires.prof_exp = 0 and thus
> > fastpath_timer_check() returns false unless we have other expired cpu timers.
> >
> > Change copy_signal() to set cputime_expires.prof_exp if we have RLIMIT_CPU.
> > Also, set cputimer.running = 1 in that case. This is not strictly necessary,
> > but imho makes sense.
>
> For -stable should this be instead of 37bebc70d7ad4144c571d74500db3bb26ec0c0eb?
Yes, sorry for confusion.
The commit above was targeted for 2.6.29, it is not optimal. When/if
"[PATCH 1/2] posix-timers: fix RLIMIT_CPU && fork()" will be merged, I'll sent
the "revert" patch.
see http://marc.info/?t=123783777600004
Oleg.
next prev parent reply other threads:[~2009-03-31 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 0:06 Oleg Nesterov
2009-03-27 23:59 ` Peter Zijlstra
2009-03-31 3:01 ` [stable] " Chris Wright
2009-03-31 14:57 ` Oleg Nesterov [this message]
2009-04-08 16:09 ` [tip:timers/urgent] " Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090331145750.GB4792@redhat.com \
--to=oleg@redhat.com \
--cc=chrisw@sous-sol.org \
--cc=ia6432@inbox.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome