From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763991AbZCaSvZ (ORCPT ); Tue, 31 Mar 2009 14:51:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763356AbZCaSoO (ORCPT ); Tue, 31 Mar 2009 14:44:14 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:40646 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763304AbZCaSoM (ORCPT ); Tue, 31 Mar 2009 14:44:12 -0400 Date: Tue, 31 Mar 2009 14:44:02 -0400 From: Christoph Hellwig To: Jeff Mahoney Cc: Linux Kernel Mailing List , Andrew Morton , Linus Torvalds , ReiserFS Development List Subject: Re: [patch 18/35 xattr-rework] reiserfs: Clean up xattrs when REISERFS_FS_XATTR is unset Message-ID: <20090331184402.GA28520@infradead.org> References: <20090330180215.951354436@suse.com> <20090330181011.592648722@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090330181011.592648722@suse.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2009 at 02:02:33PM -0400, Jeff Mahoney wrote: > The current reiserfs xattr implementation will not clean up old xattr > files if files are deleted when REISERFS_FS_XATTR is unset. This results > in inaccessible lost files, wasting space. > > This patch compiles in basic xattr knowledge, such as how to delete them and > change ownership for quota tracking. If the file system has never used > xattrs, then the operation is quite fast: it returns immediately when > it sees there is no .reiserfs_priv directory. What about just making xattr suppose unconditional? That's what most never filesystems do, and it really shouldn't be a whole lot of code.