mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Anton Blanchard <anton@samba.org>
Cc: linux-kernel@vger.kernel.org, arjan@infradead.org
Subject: Re: [PATCH] Align cache_clean work
Date: Wed, 1 Apr 2009 12:45:16 -0700	[thread overview]
Message-ID: <20090401124516.40968848.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090401104518.GG27084@kryten>

> Subject: [PATCH] Align cache_clean work

better titles, please.  Of the form

	subsystem-identifier: what-i-did-to-it

On Wed, 1 Apr 2009 21:45:18 +1100
Anton Blanchard <anton@samba.org> wrote:

> 
> Align cache_clean work.
> 
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
> 
> Index: linux-2.6/net/sunrpc/cache.c
> ===================================================================
> --- linux-2.6.orig/net/sunrpc/cache.c	2009-04-01 15:47:38.000000000 +1100
> +++ linux-2.6/net/sunrpc/cache.c	2009-04-01 16:32:44.000000000 +1100
> @@ -488,7 +488,7 @@
>  {
>  	int delay = 5;
>  	if (cache_clean() == -1)
> -		delay = 30*HZ;
> +		delay = round_jiffies_relative(30*HZ);
>  
>  	if (list_empty(&cache_list))
>  		delay = 0;

the people who will merge this patch (nfs/net) will be wondering why
they were asked to do so.

iow: better changelogs please ;)

      reply	other threads:[~2009-04-01 19:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01 10:45 Anton Blanchard
2009-04-01 19:45 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090401124516.40968848.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=anton@samba.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome