mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: trivial@kernel.org, adilger@sun.com, mkatiyar@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] : Add dev-id and inode number for debugging in  init_special_inode in fs/inode.c
Date: Wed, 1 Apr 2009 14:50:41 -0700	[thread overview]
Message-ID: <20090401145041.6681fc90.akpm@linux-foundation.org> (raw)
In-Reply-To: <ea11fea30903301941p3a5a71c2l816df9a3d8341183@mail.gmail.com>

On Tue, 31 Mar 2009 08:11:00 +0530
Manish Katiyar <mkatiyar@gmail.com> wrote:

> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -1540,7 +1540,8 @@ void init_special_inode(struct inode *inode, umode_t mode, dev_t rdev)
>  	else if (S_ISSOCK(mode))
>  		inode->i_fop = &bad_sock_fops;
>  	else
> -		printk(KERN_DEBUG "init_special_inode: bogus i_mode (%o)\n",
> -		       mode);
> +		printk(KERN_DEBUG "init_special_inode: bogus i_mode (%o) for"
> +				  " inode %s:%lu\n", mode, inode->i_sb->s_id,
> +				  inode->i_ino);
>  }

Is ther a guarantee that inode->i_sb and inode->i_ino have been initialised
at this time?

  reply	other threads:[~2009-04-01 21:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ea11fea30903222016j1d16372ct2dfd6004452e0531@mail.gmail.com>
     [not found] ` <20090330163317.a273a46a.akpm@linux-foundation.org>
2009-03-31  2:41   ` Manish Katiyar
2009-04-01 21:50     ` Andrew Morton [this message]
2009-04-03 10:35       ` Manish Katiyar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090401145041.6681fc90.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=adilger@sun.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkatiyar@gmail.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome