From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: markus@trippelsdorf.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, uwe.bugla@gmx.de
Subject: Re: [PATCH 2/2] tcp: miscounts due to tcp_fragment pcount reset
Date: Thu, 02 Apr 2009 16:32:35 -0700 (PDT) [thread overview]
Message-ID: <20090402.163235.153382360.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0904021216170.30150@wrl-59.cs.helsinki.fi>
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Thu, 2 Apr 2009 12:18:20 +0300 (EEST)
>
> It seems that trivial reset of pcount to one was not sufficient
> in tcp_retransmit_skb. Multiple counters experience a positive
> miscount when skb's pcount gets lowered without the necessary
> adjustments (depending on skb's sacked bits which exactly), at
> worst a packets_out miscount can crash at RTO if the write queue
> is empty!
>
> Triggering this requires mss change, so bidir tcp or mtu probe or
> like.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> Tested-by: Uwe Bugla <uwe.bugla@gmx.de>
Applied.
next prev parent reply other threads:[~2009-04-02 23:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 21:12 WARNING: at net/ipv4/tcp_input.c:2927 tcp_ack+0xd55/0x1991() Markus Trippelsdorf
2009-03-27 23:05 ` Ilpo Järvinen
2009-03-28 4:50 ` Markus Trippelsdorf
2009-03-28 8:29 ` Ilpo Järvinen
2009-03-28 9:55 ` Markus Trippelsdorf
2009-03-28 13:56 ` Jonathan Corbet
2009-03-30 8:51 ` Jarek Poplawski
2009-03-30 14:01 ` Jonathan Corbet
2009-03-30 16:40 ` Jarek Poplawski
2009-03-30 16:01 ` Ilpo Järvinen
2009-03-30 16:40 ` Markus Trippelsdorf
2009-03-30 18:52 ` Ilpo Järvinen
2009-03-31 7:10 ` Markus Trippelsdorf
2009-03-31 9:16 ` Ilpo Järvinen
2009-03-31 18:49 ` Markus Trippelsdorf
2009-03-31 19:12 ` Ilpo Järvinen
2009-04-01 7:00 ` Ilpo Järvinen
2009-04-01 11:09 ` Ilpo Järvinen
2009-04-01 11:35 ` Markus Trippelsdorf
2009-04-02 9:15 ` [PATCH 1/2] tcp: add helper for counter tweaking due mid-wq change Ilpo Järvinen
2009-04-02 9:18 ` [PATCH 2/2] tcp: miscounts due to tcp_fragment pcount reset Ilpo Järvinen
2009-04-02 23:32 ` David Miller [this message]
2009-04-02 23:32 ` [PATCH 1/2] tcp: add helper for counter tweaking due mid-wq change David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090402.163235.153382360.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=netdev@vger.kernel.org \
--cc=uwe.bugla@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®