From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934026AbZDBQ6z (ORCPT ); Thu, 2 Apr 2009 12:58:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760132AbZDBQ6l (ORCPT ); Thu, 2 Apr 2009 12:58:41 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:37398 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755123AbZDBQ6k (ORCPT ); Thu, 2 Apr 2009 12:58:40 -0400 Date: Thu, 2 Apr 2009 09:53:15 -0700 From: Andrew Morton To: Lee Schermerhorn Cc: linux-kernel , stable , Rik van Riel , KOSAKI Motohiro , David Howells Subject: Re: [PATCH] Define a UNIQUE value for AS_UNEVICTABLE flag Message-Id: <20090402095315.1098b6c3.akpm@linux-foundation.org> In-Reply-To: <1238690835.7359.16.camel@lts-notebook> References: <1238690835.7359.16.camel@lts-notebook> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Apr 2009 12:47:15 -0400 Lee Schermerhorn wrote: > [PATCH] Define UNIQUE value of AS_UNEVICTABLE > > Needed in 2.6.28, 2.6.29, ... > > A new "address_space flag"--AS_MM_ALL_LOCKS--was defined to use the next > available AS flag while the Unevictable LRU was under development. The > Unevictable LRU was using the same flag and "no one" noticed. Current > mainline, since 2.6.28, has same value for two symbolic flag names. argh. What are the user-observable effects of the bug, and why didn't anyone notice it until now?