From: Tvrtko Ursulin <tvrtko.ursulin@sophos.com>
To: "Tvrtko A. Ursulin" <tvrtko@ursulin.net>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Pavel Machek <pavel@ucw.cz>,
"linux-pm@lists.linux-foundation.org"
<linux-pm@lists.linux-foundation.org>,
kernel list <linux-kernel@vger.kernel.org>,
Tobias Diedrich <ranma+kernel@tdiedrich.de>,
Ayaz Abdulla <aabdulla@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ed Swierk <eswierk@arastra.com>,
Arthur Jones <ajones@riverbed.com>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
stable@kernel.org
Subject: Re: [Regression in 2.6.29] forcedeth doesn't work after resume from hibernation (was: Re: Resume after hibernation regression in 2.6.29)
Date: Fri, 3 Apr 2009 10:23:38 +0000 [thread overview]
Message-ID: <200904031123.40390.tvrtko.ursulin@sophos.com> (raw)
In-Reply-To: <200903290903.57911.tvrtko@ursulin.net>
On Sunday 29 March 2009 09:03:57 Tvrtko A. Ursulin wrote:
> On Friday 27 March 2009 20:09:20 Rafael J. Wysocki wrote:
> > I was able to reproduce the problem and identify the commit that broke
> > the resume of forcedeth, which turned out to be:
> >
> > commit cb52deba12f27af90a46d2f8667a64888118a888
> > Author: Ed Swierk <eswierk@arastra.com>
> > Date: Mon Dec 1 12:24:43 2008 +0000
> >
> > forcedeth: power down phy when interface is down
> >
> > Signed-off-by: Ed Swierk <eswierk@arastra.com>
> > Tested-by: Arthur Jones <ajones@riverbed.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> >
> > Since I have no slightest idea of what this commit is supposed to
> > achieve, I can only ask for reverting it. It reverts cleanly, BTW.
>
> Reverting this fixes it for me as well.
>
> Thanks for your effort!
Would reverting this be a -stable material?
Tvrtko
next prev parent reply other threads:[~2009-04-03 10:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200903261920.32173.tvrtko@ursulin.net>
2009-03-26 20:18 ` Resume after hibernation regression in 2.6.29 Pavel Machek
2009-03-26 20:55 ` Tvrtko A. Ursulin
2009-03-26 21:14 ` Pavel Machek
2009-03-26 21:35 ` Rafael J. Wysocki
2009-03-26 22:01 ` Tvrtko A. Ursulin
2009-03-26 22:38 ` Pavel Machek
2009-03-26 23:04 ` Tvrtko A. Ursulin
2009-03-26 23:08 ` Rafael J. Wysocki
2009-03-27 8:01 ` Tvrtko A. Ursulin
2009-03-27 11:55 ` Rafael J. Wysocki
2009-03-27 20:09 ` [Regression in 2.6.29] forcedeth doesn't work after resume from hibernation (was: Re: Resume after hibernation regression in 2.6.29) Rafael J. Wysocki
2009-03-29 8:03 ` Tvrtko A. Ursulin
2009-04-03 10:23 ` Tvrtko Ursulin [this message]
2009-04-03 15:24 ` Ed Swierk
2009-04-03 17:41 ` Ed Swierk
2009-04-03 20:26 ` Rafael J. Wysocki
2009-04-04 13:04 ` Tvrtko A. Ursulin
2009-04-04 13:07 ` Rafael J. Wysocki
2009-03-27 8:39 ` Resume after hibernation regression in 2.6.29 Tobias Diedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904031123.40390.tvrtko.ursulin@sophos.com \
--to=tvrtko.ursulin@sophos.com \
--cc=aabdulla@nvidia.com \
--cc=ajones@riverbed.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eswierk@arastra.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=ranma+kernel@tdiedrich.de \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
--cc=tvrtko@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®