From: Nick Piggin <nickpiggin@yahoo.com.au>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/4] CacheFiles: Revert the addition of write_one_page()
Date: Sat, 4 Apr 2009 16:55:42 +1100 [thread overview]
Message-ID: <200904041655.43360.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <10983.1238766809@redhat.com>
On Saturday 04 April 2009 00:53:29 David Howells wrote:
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > Note that in the patch series going into mainline eventually this should
> > not be a separate patch but the new ops should never be introduced.
>
> Yes, probably, but this makes it easier for people to see what I'm proposing
> to change.
Definitely yes please. kmap resources are not infinite but there is obviously
a proper kmap allocator so long as you only kmap one page at a time, then
others will just block waiting for more. On sane platforms of course there
is no penalty at all.
So this change is definitely required if you want to get this patchset in.
The alternative is to come up with a new API and get that merged first, but
I figure you don't want that kind of dependency.
next prev parent reply other threads:[~2009-04-04 5:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-03 9:41 [PATCH 1/4] CacheFiles: Use the ->write() file op rather than a special kernel aop David Howells
2009-04-03 9:41 ` [PATCH 2/4] CacheFiles: Revert the addition of write_one_page() David Howells
2009-04-03 13:50 ` Christoph Hellwig
2009-04-03 13:53 ` David Howells
2009-04-04 5:55 ` Nick Piggin [this message]
2009-04-03 9:41 ` [PATCH 3/4] FS-Cache: Use a radix tree to track pages being written rather than a page flag David Howells
2009-04-03 9:41 ` [PATCH 4/4] FS-Cache: Revert the addition of PG_owner_priv2/PG_fscache_write David Howells
2009-04-03 9:51 ` [PATCH 1/4] CacheFiles: Use the ->write() file op rather than a special kernel aop David Howells
2009-04-03 13:49 ` Christoph Hellwig
2009-04-03 13:57 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904041655.43360.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®