mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Len Brown <lenb@kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] PM: Warn if interrupts are enabled during suspend-resume of sysdevs
Date: Sun, 5 Apr 2009 15:51:08 +0200	[thread overview]
Message-ID: <20090405135108.GC25250@elte.hu> (raw)
In-Reply-To: <200904042323.19866.rjw@sisk.pl>


* Rafael J. Wysocki <rjw@sisk.pl> wrote:

> From: Rafael J. Wysocki <rjw@sisk.pl>
> 
> Sysdev have to be suspended and resumed with interrupts disabled 
> and things usually break in a way that's difficult to debug if one 
> of sysdev drivers enables interrupts by mistake during suspend or 
> resume.  Add extra checks that will generate warnings in such 
> cases.

no objections - but obviously the real solution would be to finish 
PeterZ's "detect assymetric kernel functions" patch:

That patch (Peter posted an initial version of it already on lkml) 
works the following way:

the ftrace function-graph-tracer plugin is utilized to instrument 
every function call in the kernel. That is extended with the 
following check: every function except __lockfunc and __sched 
functions must be 'balanced' - i.e. they must enter and exit with 
the same IRQ flags, preempt count and lock depth counter.

	Ingo

  parent reply	other threads:[~2009-04-05 13:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-04 21:23 Rafael J. Wysocki
2009-04-04 22:03 ` Frans Pop
2009-04-04 22:10   ` Rafael J. Wysocki
2009-04-05 13:51 ` Ingo Molnar [this message]
2009-04-05 17:39   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090405135108.GC25250@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®