From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758618AbZDFPjE (ORCPT ); Mon, 6 Apr 2009 11:39:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756625AbZDFPf2 (ORCPT ); Mon, 6 Apr 2009 11:35:28 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:56991 "EHLO t61.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756598AbZDFPf1 (ORCPT ); Mon, 6 Apr 2009 11:35:27 -0400 From: Alan Cox Subject: [PATCH 16/27] isicom: isicom kref leak fix To: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org Date: Mon, 06 Apr 2009 17:33:55 +0100 Message-ID: <20090406163353.12934.38086.stgit@t61.ukuu.org.uk> In-Reply-To: <20090406162959.12934.97904.stgit@t61.ukuu.org.uk> References: <20090406162959.12934.97904.stgit@t61.ukuu.org.uk> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The isicom driver leaks a kref on the shutdown path. Drop the additional kref we took Signed-off-by: Alan Cox --- drivers/char/isicom.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/char/isicom.c b/drivers/char/isicom.c index 24aa6e8..a59eac5 100644 --- a/drivers/char/isicom.c +++ b/drivers/char/isicom.c @@ -925,6 +925,7 @@ static void isicom_shutdown_port(struct isi_port *port) if (!card->count) isicom_shutdown_board(card); } + tty_kref_put(tty); } static void isicom_flush_buffer(struct tty_struct *tty)