From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Elina <epasheva@sierrawireless.com>
Cc: <gregkh@suse.de>, <rfiler@sierrawireless.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 003/003] USB: serial: sierra driver bug fixes in open/close and callbacks
Date: Tue, 7 Apr 2009 12:11:04 +0100 [thread overview]
Message-ID: <20090407121104.718d109a@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1239062762.10120.38.camel@Linuxdev3>
On Mon, 6 Apr 2009 17:06:02 -0700
Elina <epasheva@sierrawireless.com> wrote:
> Subject: [PATCH 003/003] USB: serial: sierra driver bug fixes in
> open/close and callbacks
> From: Elina Pasheva <epasheva@sierrawireless.com>
NAK this patch
It puts back stuff that was removed in other bug fixing (eg
tty->low_latency setting). Some of the other stuff looks odd too - but
its hard to read with the mixing of formatting/debug changes and other
code changes.
The tty = NULL assignment for one makes no sense.
prev parent reply other threads:[~2009-04-07 11:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 0:06 Elina
2009-04-07 1:02 ` Greg KH
2009-04-07 11:11 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090407121104.718d109a@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=epasheva@sierrawireless.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rfiler@sierrawireless.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®