From: Ingo Molnar <mingo@elte.hu>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: srostedt@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6.30-rc1] Append a comma to INIT_FTRACE_GRAPH.
Date: Wed, 8 Apr 2009 10:25:31 +0200 [thread overview]
Message-ID: <20090408082531.GA5648@elte.hu> (raw)
In-Reply-To: <200904080505.n3855hcn017109@www262.sakura.ne.jp>
* Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote:
> Due to lack of a comma, build fails if elements are appended to
> INIT_TASK() macro.
>
> arch/x86/kernel/init_task.c:33: error: request for member `XXXXXXXXXX' in something not a structure or union
> arch/x86/kernel/init_task.c:33: error: initializer element is not constant
> arch/x86/kernel/init_task.c:33: error: (near initialization for `init_task.ret_stack')
> make[1]: *** [arch/x86/kernel/init_task.o] Error 1
> make: *** [arch/x86/kernel] Error 2
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> ---
> include/linux/ftrace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to tip:tracing/urgent, thanks. (It is not a problem right
now because this is the last in the line, but it will become a
problem the moment something is appended.)
Ingo
next prev parent reply other threads:[~2009-04-08 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 5:05 Tetsuo Handa
2009-04-08 8:25 ` Ingo Molnar [this message]
2009-04-08 8:27 ` [tip:tracing/urgent] tracing: append " Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408082531.GA5648@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®