From: Ingo Molnar <mingo@elte.hu>
To: Tom Zanussi <tzanussi@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
fweisbec@gmail.com
Subject: Re: [PATCH v2] tracing/filters: use ring_buffer_discard_commit() in filter_check_discard()
Date: Wed, 8 Apr 2009 11:14:32 +0200 [thread overview]
Message-ID: <20090408091432.GA10381@elte.hu> (raw)
In-Reply-To: <20090408085635.GA6203@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> * Ingo Molnar <mingo@elte.hu> wrote:
>
> > * Tom Zanussi <tzanussi@gmail.com> wrote:
> >
> > > This patch changes filter_check_discard() to make use of the new
> > > ring_buffer_discard_commit() function and modifies the current
> > > users to call the old commit function in the non-discard case. It
> > > also introduces a version of filter_check_discard() that uses the
> > > global trace buffer (filter_current_check_discard()) for those
> > > cases.
> > >
> > > v2 changes:
> > >
> > > - fix compile error noticed by Ingo Molnar
> > >
> > > Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
> >
> > Thanks Tom, i've applied it to tip:tracing/filters and i've started
> > testing it.
>
> still has build failures:
>
> kernel/built-in.o: In function `filter_check_discard':
> trace.c:(.text+0x5b057): undefined reference to `filter_match_preds'
ah, i'll try your other patch as well that separates the event
infrastructre from the event-tracer.
Ingo
next prev parent reply other threads:[~2009-04-08 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 8:15 Tom Zanussi
2009-04-08 8:44 ` Ingo Molnar
2009-04-08 8:56 ` Ingo Molnar
2009-04-08 9:14 ` Ingo Molnar [this message]
2009-04-13 22:23 ` [tip:tracing/core] " tip-bot for Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408091432.GA10381@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome