From: Kyle McMartin <kyle@mcmartin.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parport: Use the PCI IRQ if offered
Date: Mon, 13 Apr 2009 00:46:43 -0400 [thread overview]
Message-ID: <20090413044643.GA6072@bombadil.infradead.org> (raw)
In-Reply-To: <20090407143009.31233.22016.stgit@t61.ukuu.org.uk>
On Tue, Apr 07, 2009 at 03:30:57PM +0100, Alan Cox wrote:
> PCI parallel port devices can IRQ share so we should stop them hogging the
> line and making a mess on modern PC systems. We know the sharing side works
> as the PCMCIA driver has shared the parallel port IRQ for some time.
>
> Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
> +extern struct parport *parport_pc_probe_port(unsigned long base,
> + unsigned long base_hi,
> + int irq, int dma,
> + struct device *dev,
> + int irqflags);
> +extern void parport_pc_unregister_port(struct parport *p);
>
You missed a bunch of uses of parport_pc_probe_port and broke the build
on powerpc, sparc, parisc, and probably several more.
regards, Kyle
next prev parent reply other threads:[~2009-04-13 4:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 14:30 Alan Cox
2009-04-07 15:52 ` Jeff Garzik
2009-04-13 4:46 ` Kyle McMartin [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-26 20:56 Alan Cox
2009-03-26 22:40 ` Jeff Garzik
2009-03-31 19:31 ` Gabor Kovacs
2009-03-31 19:23 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413044643.GA6072@bombadil.infradead.org \
--to=kyle@mcmartin.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®