From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: romieu@fr.zoreil.com, netdev@vger.kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix velocity_intr() in the VIA Velocity driver to have the right return type
Date: Tue, 14 Apr 2009 14:20:14 -0700 (PDT) [thread overview]
Message-ID: <20090414.142014.53605891.davem@davemloft.net> (raw)
In-Reply-To: <20090414155325.27548.90325.stgit@warthog.procyon.org.uk>
From: David Howells <dhowells@redhat.com>
Date: Tue, 14 Apr 2009 16:53:25 +0100
> Fix velocity_intr() in the VIA Velocity driver to have the right return type.
> As it stands, it returns the right values, but as type int, not type
> irqreturn_t. This leads to the following compiler warning:
>
> CC drivers/net/via-velocity.o
> drivers/net/via-velocity.c: In function 'velocity_open':
> drivers/net/via-velocity.c:1924: warning: passing argument 2 of 'request_irq' from incompatible pointer type
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Already fixed in net-2.6
prev parent reply other threads:[~2009-04-14 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 15:53 David Howells
2009-04-14 21:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090414.142014.53605891.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®