From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Oliver Neukum <oliver@neukum.org>
Cc: Chuck Ebbert <cebbert@redhat.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: Scheduling while atomic in tty code with cdc-acm driver, kernel 2.6.29.1
Date: Tue, 14 Apr 2009 07:12:04 +0100 [thread overview]
Message-ID: <20090414071204.2450b6a0@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200904140150.10790.oliver@neukum.org>
On Tue, 14 Apr 2009 01:50:10 +0200
Oliver Neukum <oliver@neukum.org> wrote:
> Am Dienstag 14 April 2009 01:36:33 schrieb Chuck Ebbert:
> > BUG: sleeping function called from invalid context at kernel/mutex.c:88
> > in_atomic(): 1, irqs_disabled(): 0, pid: 0, name: swapper
> > Pid: 0, comm: swapper Not tainted 2.6.29.1-54.fc11.x86_64 #1
>
> Is this specific to 2.6.29.1? It looks like setting low_latency, as cdc-acm,
> does for legacy reasons, is harmful now. Please remove these lines:
The only thing that has changed is that this incorrect behaviour (setting
low_latency and doing a flip_buffer_push() in IRQ context) now causes a
warn rather than random failure.
The hack setting of it for high data rate devices was obsolete when the
tty buffer changes went in so it can definitely go in those cases.
prev parent reply other threads:[~2009-04-14 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 23:36 Chuck Ebbert
2009-04-13 23:50 ` Oliver Neukum
2009-04-14 6:12 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090414071204.2450b6a0@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=cebbert@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®