From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <srostedt@redhat.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: TRACE_BRANCH_PROFILING breaks gcc warnings
Date: Wed, 15 Apr 2009 09:37:20 +0200 [thread overview]
Message-ID: <20090415073720.GC18192@elte.hu> (raw)
In-Reply-To: <1239748293.21121.60.camel@localhost.localdomain>
* Steven Rostedt <srostedt@redhat.com> wrote:
>
> On Wed, 2009-04-15 at 00:28 +0200, Johannes Berg wrote:
> > With TRACE_BRANCH_PROFILING enabled you get "dummy may be used
> > uninitialised" with code like the following (and gcc 4.3.3):
> >
> > void *dummy, *c;
> >
> > if (a && (dummy = b()))
> > c = dummy;
> >
> > Therefore, allyesconfig has become useless for looking at warnings.
There's an easy solution for that problem btw: you just have to
disable the branch tracer after allyesconfig. [ Or fix the compiler.
Or both ;-) ]
I'm also curious, how often do you do allyesconfig builds? I've
never seen you report one before. Have you started doing them
recently? How much time does it take on your system?
> > :(
>
> This has been mentioned before, and I've asked about sending a
> patch that would prevent TRACE_BRANCH_PROFILING from being
> selected with an allyesconfig.
>
> It is easy to do. I could make it a selection and not a boolean
> and it will not select it as default, even for allyes/modconfig
>
> Thoughts?
That's a good idea - please send a patch.
Ingo
next prev parent reply other threads:[~2009-04-15 7:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 22:28 Johannes Berg
2009-04-14 22:31 ` Steven Rostedt
2009-04-15 7:37 ` Ingo Molnar [this message]
2009-04-15 7:46 ` Sam Ravnborg
2009-04-15 8:12 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090415073720.GC18192@elte.hu \
--to=mingo@elte.hu \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome