From: Christoph Hellwig <hch@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Problem with CREATE_TRACE_POINTS and recursion safety
Date: Thu, 16 Apr 2009 07:09:20 -0400 [thread overview]
Message-ID: <20090416110920.GB10487@infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.00.0904152302530.4459@gandalf.stny.rr.com>
On Wed, Apr 15, 2009 at 11:09:14PM -0400, Steven Rostedt wrote:
> I hate to do this because it adds some more work to the developer adding a
> new trace point header, but we could just remove the CREATE_TRACE_POINTS
> and do in the trace/events/*.h headers:
>
> #ifdef CREATE_FOO_TRACE_POINTS
> #include <trace/define_trace.h>
> #endif
>
> in all tracepoint headers. I originally had it this way with just the
> CREATE_TRACE_POINTS, but Christoph Hellwig and Mathieu both suggested
> putting that into define_trace.h. It seems so much cleaner to keep it in
> define_trace.h, but if it is causing too many headaches, it may not be
> worth it :-/
I still don't like the magic include in every trace header.
What about
#define CREATE_FOO_TRACE_POINTS "subsystem"
to only create them for a given subsystem?
next prev parent reply other threads:[~2009-04-16 11:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 0:34 Jeremy Fitzhardinge
2009-04-16 0:56 ` Steven Rostedt
2009-04-16 1:06 ` Jeremy Fitzhardinge
2009-04-16 2:02 ` Steven Rostedt
2009-04-16 2:23 ` Mathieu Desnoyers
2009-04-16 2:50 ` Jeremy Fitzhardinge
2009-04-16 3:09 ` Steven Rostedt
2009-04-16 11:09 ` Christoph Hellwig [this message]
2009-04-16 13:42 ` Steven Rostedt
2009-04-16 2:45 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416110920.GB10487@infradead.org \
--to=hch@infradead.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®