Re: [PATCH] [0/28] x86: MCE: Feature series for 2.6.31

[Andi Kleen <andi@firstfloor.org>]

On Fri, Apr 17, 2009 at 08:24:34PM +0900, Hidetoshi Seto wrote:
> Andi Kleen wrote:
> > Various new Intel x86 machine check features, including initial support
> > for machine check recovery and new status bits. The actual machine check
> > recovery requires some generic VM changes, which will be posted in a separate
> > series ("POISON series") This series can be applied without the POISON
> > series and POISON requires these patches.
> > 
> > Especially the broadcast and early nowayout patches are fairly important for 
> > Nehalem CPUs, without them machine checks are often incorrectly reported
> > due to the shared bank topology of the system.
> > 
> > -Andi
> 
> Andi, could you divide this series into "cleanups" and "features"?

There is very little classic cleanup (as in make code prettier
to read and do nothing else) in this series, it's pretty much all features or 
feature like fixes. 

The ones that could be seen as cleanups are:

x86: MCE: Remove unused mce_events variable
x86: MCE: Use symbolic macros to access MCG_CAP register
x86: MCE: Remove mce_init unused argument
x86: MCE: Rename and align out2 label

That one is technically a cleanup, but I would argue it's a fix because
it shrinks code size:

x86: MCE: Use extended sysattrs for the check_interval attribute.

That one could be see as cleanup too although I personally consider removing
BKL feature too:

x86: MCE: Drop BKL in mce_open

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.