RE: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable drivers for Microblaze

[Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>]

> -----Original Message-----
> From: owner-microblaze-uclinux@itee.uq.edu.au [mailto:owner-microblaze-uclinux@itee.uq.edu.au] On
> Behalf Of Grant Likely
> Sent: Thursday, April 16, 2009 11:52 PM
> To: John Williams
> Cc: microblaze-uclinux@itee.uq.edu.au; linux-kernel@vger.kernel.org; Michal Simek
> Subject: Re: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable drivers for Microblaze
> 
> On Thu, Apr 16, 2009 at 11:01 PM, John Williams
> <john.williams@petalogix.com> wrote:
> > On Thu, Apr 16, 2009 at 7:56 PM,  <monstr@monstr.eu> wrote:
> >> From: Michal Simek <monstr@monstr.eu>
> >>
> >> Signed-off-by: Michal Simek <monstr@monstr.eu>
> >
> > ACK from a MicroBlaze perspective, but some other comments below:
> 
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> 
> But I'm not sure who should pick this up.
> 
> >
> > A note more for the Xilinx PPC folks (ie Grant Likely):
> >
> > Shouldn't some of these Kconfig depends for PPC be unified?  We have:
> >
> >>  config XILINX_SYSACE
> >>        tristate "Xilinx SystemACE support"
> >> -       depends on 4xx
> >> +       depends on 4xx || MICROBLAZE
> >
> >>  config XILINX_HWICAP
> >>        tristate "Xilinx HWICAP Support"
> >> -       depends on XILINX_VIRTEX
> >> +       depends on XILINX_VIRTEX || MICROBLAZE
> >
> >
> >>  config GPIO_XILINX
> >>        bool "Xilinx GPIO support"
> >> -       depends on PPC_OF
> >> +       depends on PPC_OF || MICROBLAZE
> >>        help
> >>          Say yes here to support the Xilinx FPGA GPIO device
> >
> > Are these all really different options?  PPC_OF?  XILINX_VIRTEX?  4xx?
> 
> xsysace should just depend on either PPC or OF.  It is applicable to
> more than just virtex/spartan systems (I know of at least one
> non-virtex 440 board with a systemace, hence the 4xx usage), and it is
> conceivable that it would be used on other architectures.
> 
> XILINX_VIRTEX makes some sense for hwicap
> 
> PPC_OF doesn't have any real meaning anymore.  PPC would be better.

I'd like to see a single configuration option that makes all of these drivers available.  That way, any processor system (x86, soft arm core, etc.) could turn those on.. The only thing these drivers *REALLY* depend on is OF...  I've circulated patches to do this several times, although they're probably hopelessly out of date at this point.

Steve

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.