From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754891AbZDTJIz (ORCPT ); Mon, 20 Apr 2009 05:08:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754835AbZDTJI3 (ORCPT ); Mon, 20 Apr 2009 05:08:29 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:59070 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754803AbZDTJI1 (ORCPT ); Mon, 20 Apr 2009 05:08:27 -0400 Date: Mon, 20 Apr 2009 02:08:19 -0700 (PDT) Message-Id: <20090420.020819.234015726.davem@davemloft.net> To: divy@chelsio.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, swise@opengridcomputing.com Subject: Re: [PATCH 2.6.30 2/4] cxgb3: fix workqueue flush issues From: David Miller In-Reply-To: <20090417222117.8504.11164.stgit@speedy5> References: <20090417222117.8504.11164.stgit@speedy5> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Divy Le Ray Date: Fri, 17 Apr 2009 15:21:17 -0700 > The fatal error task can be scheduled while processing an offload packet > in NAPI context when the connection handle is bogus. this can race > with the ports being brought down and the cxgb3 workqueue being flushed. > Stop napi processing before flushing the work queue. > > The ULP drivers (iSCSI, iWARP) might also schedule a task on keventd_wk > while releasing a connection handle (cxgb3_offload.c::cxgb3_queue_tid_release()). > The driver however does not flush any work on keventd_wq while being unloaded. > This patch also fixes this. > > Also call cancel_delayed_work_sync in place of the the deprecated > cancel_rearming_delayed_workqueue. > > Signed-off-by: Divy Le Ray Applied.