mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jack Steiner <steiner@sgi.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] - Memoryless nodes
Date: Mon, 20 Apr 2009 08:10:49 -0500	[thread overview]
Message-ID: <20090420131049.GA11839@sgi.com> (raw)
In-Reply-To: <87hc0mqqtd.fsf@basil.nowhere.org>

On Sat, Apr 18, 2009 at 11:00:46AM +0200, Andi Kleen wrote:
> Jack Steiner <steiner@sgi.com> writes:
> 
> > Add support for nodes that have cpus but no memory.
> > The current code was failing to add these nodes
> > to the nodes_present_map.
> 
> That was intentional because a node is defined as an area of memory
> and an area of memory without memory didn't seem to make sense.
> I still don't think it does. Instead the CPUs are assigned
> to nearby nodes. Back then the generic code also couldn't deal
> with them at all, so you might well run into more problems.


Nodes can also be viewed as a collection of cpus and memory that are
located "close together" - ie., same PXM in the SRAT. Normally nodes will
have both memory & cpus but in theory either cpus or memory could be
missing.

I have run a number of tests of nodes with cpus only and so far have not
seen any issues. I certainly won't rule out problems but have not seen
them yet.

If there are any corner cases that you are aware of, let me know & I can
do some more targeted testing.

(Note: this is not a bizarre end case that I'm trying to fix. UV actually
has blades with cpus and no memory available to the OS.)

--- jack


      reply	other threads:[~2009-04-20 13:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-17 14:22 Jack Steiner
2009-04-17 14:49 ` [tip:x86/urgent] x86/uv: fix init of memory-less nodes tip-bot for Jack Steiner
2009-04-17 18:31   ` David Rientjes
2009-04-17 20:28     ` Jack Steiner
2009-04-17 20:45 ` tip-bot for Jack Steiner
2009-04-18  9:00 ` [PATCH] - Memoryless nodes Andi Kleen
2009-04-20 13:10   ` Jack Steiner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090420131049.GA11839@sgi.com \
    --to=steiner@sgi.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome