mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Izik Eidus <ieidus@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: mmotm 2009-04-21-15-00 uploaded
Date: Wed, 22 Apr 2009 05:45:16 +0300	[thread overview]
Message-ID: <20090422054516.122ac635@woof.tlv.redhat.com> (raw)
In-Reply-To: <20090421185313.06bec1cc.akpm@linux-foundation.org>

On Tue, 21 Apr 2009 18:53:13 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 21 Apr 2009 18:30:57 -0700 Randy Dunlap
> <randy.dunlap@oracle.com> wrote:
> 
> > akpm@linux-foundation.org wrote:
> > > The mm-of-the-moment snapshot 2009-04-21-15-00 has been uploaded
> > > to
> > > 
> > >    http://userweb.kernel.org/~akpm/mmotm/
> > > 
> > > and will soon be available at
> > > 
> > >    git://git.zen-sources.org/zen/mmotm.git
> > > 
> > > It contains the following patches against 2.6.30-rc2:
> > 
> > 
> > 2 of 10 i386 builds ended like:
> > 
> > 
> >   CC      arch/x86/kernel/asm-offsets.s
> > In file included from include/linux/suspend.h:8,
> >                  from arch/x86/kernel/asm-offsets_32.c:11,
> >                  from arch/x86/kernel/asm-offsets.c:2:
> > include/linux/mm.h: In function 'get_pte':
> > include/linux/mm.h:907: error: implicit declaration of function
> > 'kmap_atomic_pte' make[2]: *** [arch/x86/kernel/asm-offsets.s]
> > Error 1 make[1]: *** [prepare0] Error 2
> > make: *** [sub-make] Error 2
> > 
> > 
> > 
> > config attached.
> 
> Caused by ksm-add-get_pte-helper-function-fetching-pte-for-va.patch.
> 
> hm, this will end badly.  Let's uninline it.
> 

Yes, anyway let include this patch that remove the usage of
asm\types.h, we sure dont need this header.
(it doesnt look risky as linux\types.h by itself will include it, but
i have bad feeling about it)

Thanks.

>From fc71a2c22019b1f0389b249e5987b0b2a208764f Mon Sep 17 00:00:00 2001
From: Izik Eidus <ieidus@redhat.com>
Date: Wed, 22 Apr 2009 05:24:03 +0300
Subject: [PATCH] ksm: ksm.h remove the asm\types.h header usage

We surely dont need it, as we include linux\types.h above, that will
include that anyway.

Signed-off-by: Izik Eidus <ieidus@redhat.com>
---
 include/linux/ksm.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/include/linux/ksm.h b/include/linux/ksm.h
index 2c11e9a..c0849c7 100644
--- a/include/linux/ksm.h
+++ b/include/linux/ksm.h
@@ -8,8 +8,6 @@
 #include <linux/types.h>
 #include <linux/ioctl.h>
 
-#include <asm/types.h>
-
 #define KSM_API_VERSION 1
 
 #define ksm_control_flags_run 1
-- 
1.5.6.5


      reply	other threads:[~2009-04-22  2:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200904212219.n3LMJ2O7007301@imap1.linux-foundation.org>
2009-04-22  1:30 ` Randy Dunlap
2009-04-22  1:53   ` Andrew Morton
2009-04-22  2:45     ` Izik Eidus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090422054516.122ac635@woof.tlv.redhat.com \
    --to=ieidus@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®