mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, linux-kernel@vger.kernel.org
Subject: [PATCH 15/17] arm: user_regset: thread pointer in core dumps
Date: Fri, 24 Apr 2009 17:14:24 -0700 (PDT)	[thread overview]
Message-ID: <20090425001424.40568FC3C8@magilla.sf.frob.com> (raw)
In-Reply-To: Roland McGrath's message of  Friday, 24 April 2009 17:06:34 -0700 <20090425000634.313E4FC3C8@magilla.sf.frob.com>

This wires up a proper user_regset for the $tp special register.
It will appear in ELF core dumps in its own tiny note of the new
type NT_ARM_TP.  The note will be omitted if $tp was 0.

Signed-off-by: Roland McGrath <roland@redhat.com>
---
 arch/arm/kernel/ptrace.c |   37 +++++++++++++++++++++++++++++++++++++
 include/linux/elf.h      |    1 +
 2 files changed, 38 insertions(+), 0 deletions(-)

diff --git a/arch/arm/kernel/ptrace.c b/arch/arm/kernel/ptrace.c
index 6ce3deb..1a07257 100644
--- a/arch/arm/kernel/ptrace.c
+++ b/arch/arm/kernel/ptrace.c
@@ -623,6 +623,37 @@ static int user_fp_set(struct task_struct *target,
 				  &thread->fpstate, 0, sizeof(struct user_fp));
 }
 
+/*
+ * Fetch the thread pointer as a regset of its own.
+ * It's considered "active" (i.e. worth dumping) if it's nonzero.
+ */
+
+static int tp_get(struct task_struct *target,
+		  const struct user_regset *regset,
+		  unsigned int pos, unsigned int count,
+		  void *kbuf, void __user *ubuf)
+{
+	return user_regset_copyout(&pos, &count, &kbuf, &ubuf,
+				   &task_thread_info(target)->tp_value,
+				   0, sizeof(unsigned long));
+}
+
+static int tp_set(struct task_struct *target,
+		  const struct user_regset *regset,
+		  unsigned int pos, unsigned int count,
+		  const void *kbuf, const void __user *ubuf)
+{
+	return user_regset_copyin(&pos, &count, &kbuf, &ubuf,
+				  &task_thread_info(target)->tp_value,
+				  0, sizeof(unsigned long));
+}
+
+static int tp_active(struct task_struct *target,
+		     const struct user_regset *regset)
+{
+	return task_thread_info(target)->tp_value == 0 ? 0 : 1;
+}
+
 #ifdef CONFIG_IWMMXT
 
 /*
@@ -806,6 +837,7 @@ static int vfp_set(struct task_struct *target,
 enum {
 	REGSET_GPR,
 	REGSET_FP,
+	REGSET_TP,
 #ifdef CONFIG_VFP
 	REGSET_VFP,
 #endif
@@ -829,6 +861,11 @@ static const struct user_regset arm_regsets[] = {
 		.size = sizeof(long), .align = sizeof(long),
 		.active = user_fp_active, .get = user_fp_get, .set = user_fp_set
 	},
+	[REGSET_TP] = {
+		.core_note_type = NT_ARM_TP,
+		.size = sizeof(long), .align = sizeof(long), .n = 1,
+		.active = tp_active, .get = tp_get, .set = tp_set
+	},
 #ifdef CONFIG_VFP
 	[REGSET_VFP] = {
 		.core_note_type = NT_PRXFPREG,
diff --git a/include/linux/elf.h b/include/linux/elf.h
index 30a7b92..32662e3 100644
--- a/include/linux/elf.h
+++ b/include/linux/elf.h
@@ -363,6 +363,7 @@ typedef struct elf64_shdr {
 #define NT_386_IOPERM	0x201		/* x86 io permission bitmap (1=deny) */
 #define NT_ARM_WMMX	0x300		/* ARM iWMMXt registers */
 #define NT_ARM_CRUNCH	0x301		/* ARM Crunch registers */
+#define NT_ARM_TP	0x302		/* ARM thread pointer */
 
 
 /* Note header in a PT_NOTE section */

  parent reply	other threads:[~2009-04-25  0:16 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-25  0:06 [PATCH 0/17] tracehook & user_regset for ARM Roland McGrath
2009-04-25  0:07 ` [PATCH 01/17] arm: arch_ptrace clean-up Roland McGrath
2009-06-19  9:13   ` Russell King
2009-06-24  6:55     ` Roland McGrath
2009-04-25  0:08 ` [PATCH 02/17] arm: arch_ptrace indentation Roland McGrath
2009-04-25  0:08 ` [PATCH 03/17] arm: tracehook_report_syscall Roland McGrath
2009-04-25  0:09 ` [PATCH 04/17] arm: tracehook_signal_handler Roland McGrath
2009-04-25  0:09 ` [PATCH 05/17] arm: TIF_NOTIFY_RESUME Roland McGrath
2009-04-25  0:10 ` [PATCH 06/17] arm: user_regset: general regs Roland McGrath
2009-04-25  0:10 ` [PATCH 07/17] arm: user_regset: FPU regs Roland McGrath
2009-04-25  0:11 ` [PATCH 08/17] arm: CORE_DUMP_USE_REGSET Roland McGrath
2009-04-25  0:11 ` [PATCH 09/17] arm: user_regset: VFP regs Roland McGrath
2009-04-25  0:12 ` [PATCH 10/17] arm: user_regset: VFP in core dumps Roland McGrath
2009-04-25  0:12 ` [PATCH 11/17] arm: user_regset: iWMMXt regs Roland McGrath
2009-04-25  0:12 ` [PATCH 12/17] arm: user_regset: iWMMXt in core dumps Roland McGrath
2009-04-27 22:43   ` Paul Mundt
2009-04-28  2:53     ` Roland McGrath
2009-04-25  0:13 ` [PATCH 13/17] arm: user_regset: Crunch regs Roland McGrath
2009-04-25  0:13 ` [PATCH 14/17] arm: user_regset: Crunch in core dumps Roland McGrath
2009-04-25  0:14 ` Roland McGrath [this message]
2009-04-25  0:15 ` [PATCH 16/17] arm: asm/syscall.h (unfinished) Roland McGrath
2009-06-19  9:31   ` Russell King
2009-06-24  8:56     ` Roland McGrath
2009-04-25  0:15 ` [PATCH 17/17] arm: HAVE_ARCH_TRACEHOOK Roland McGrath
2009-06-06 14:42 ` [PATCH 0/17] tracehook & user_regset for ARM Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090425001424.40568FC3C8@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®