mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Tim Abbott <tabbott@MIT.EDU>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Anders Kaseorg <andersk@MIT.EDU>, Waseem Daher <wdaher@MIT.EDU>,
	Denys Vlasenko <vda.linux@googlemail.com>,
	Jeff Arnold <jbarnold@MIT.EDU>, Paul Mundt <lethal@linux-sh.org>,
	David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 2/8] frv: Use __INIT macro instead of .text.init.
Date: Mon, 27 Apr 2009 20:37:38 +0200	[thread overview]
Message-ID: <20090427183737.GB12056@uranus.ravnborg.org> (raw)
In-Reply-To: <1240855347-19316-3-git-send-email-tabbott@mit.edu>

On Mon, Apr 27, 2009 at 02:02:21PM -0400, Tim Abbott wrote:
> frv is placing some code in the .text.init section but does not
> reference that section in its linker scripts.
> 
> This change moves this code from the .text.init section to the
> .init.text section, which is presumably where it belongs.

I checked a few of the assembler entries - they where all
called from __HEAD section.
So this change looks good.

> 
> Signed-off-by: Tim Abbott <tabbott@mit.edu>
> Cc: David Howells <dhowells@redhat.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> ---
>  arch/frv/kernel/head-mmu-fr451.S |    3 ++-
>  arch/frv/kernel/head-uc-fr401.S  |    3 ++-
>  arch/frv/kernel/head-uc-fr451.S  |    3 ++-
>  arch/frv/kernel/head-uc-fr555.S  |    3 ++-
>  4 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/frv/kernel/head-mmu-fr451.S b/arch/frv/kernel/head-mmu-fr451.S
> index c8f210d..98f87d5 100644
> --- a/arch/frv/kernel/head-mmu-fr451.S
> +++ b/arch/frv/kernel/head-mmu-fr451.S
> @@ -9,6 +9,7 @@
>   * 2 of the License, or (at your option) any later version.
>   */
>  
> +#include <linux/init.h>
>  #include <linux/threads.h>
>  #include <linux/linkage.h>
>  #include <asm/ptrace.h>
> @@ -31,7 +32,7 @@
>  #define __400_LCR	0xfe000100
>  #define __400_LSBR	0xfe000c00
>  
> -	.section	.text.init,"ax"
> +	__INIT
>  	.balign		4
>  
>  ###############################################################################
> diff --git a/arch/frv/kernel/head-uc-fr401.S b/arch/frv/kernel/head-uc-fr401.S
> index ee282be..438643c 100644
> --- a/arch/frv/kernel/head-uc-fr401.S
> +++ b/arch/frv/kernel/head-uc-fr401.S
> @@ -9,6 +9,7 @@
>   * 2 of the License, or (at your option) any later version.
>   */
>  
> +#include <linux/init.h>
>  #include <linux/threads.h>
>  #include <linux/linkage.h>
>  #include <asm/ptrace.h>
> @@ -30,7 +31,7 @@
>  #define __400_LCR	0xfe000100
>  #define __400_LSBR	0xfe000c00
>  
> -	.section	.text.init,"ax"
> +	__INIT
>  	.balign		4
>  
>  ###############################################################################
> diff --git a/arch/frv/kernel/head-uc-fr451.S b/arch/frv/kernel/head-uc-fr451.S
> index b10d9c8..b2a76c4 100644
> --- a/arch/frv/kernel/head-uc-fr451.S
> +++ b/arch/frv/kernel/head-uc-fr451.S
> @@ -9,6 +9,7 @@
>   * 2 of the License, or (at your option) any later version.
>   */
>  
> +#include <linux/init.h>
>  #include <linux/threads.h>
>  #include <linux/linkage.h>
>  #include <asm/ptrace.h>
> @@ -30,7 +31,7 @@
>  #define __400_LCR	0xfe000100
>  #define __400_LSBR	0xfe000c00
>  
> -	.section	.text.init,"ax"
> +	__INIT
>  	.balign		4
>  
>  ###############################################################################
> diff --git a/arch/frv/kernel/head-uc-fr555.S b/arch/frv/kernel/head-uc-fr555.S
> index 39937c1..5497aaf 100644
> --- a/arch/frv/kernel/head-uc-fr555.S
> +++ b/arch/frv/kernel/head-uc-fr555.S
> @@ -9,6 +9,7 @@
>   * 2 of the License, or (at your option) any later version.
>   */
>  
> +#include <linux/init.h>
>  #include <linux/threads.h>
>  #include <linux/linkage.h>
>  #include <asm/ptrace.h>
> @@ -29,7 +30,7 @@
>  #define __551_LCR	0xfeff1100
>  #define __551_LSBR	0xfeff1c00
>  
> -	.section	.text.init,"ax"
> +	__INIT
>  	.balign		4
>  
>  ###############################################################################
> -- 
> 1.6.2.1
> 

  parent reply	other threads:[~2009-04-27 18:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27 18:02 [PATCH 0/8] cleanup old init and refok sections Tim Abbott
2009-04-27 18:02 ` [PATCH 1/8] frv: Remove unused header asm/init.h Tim Abbott
2009-04-27 18:02   ` [PATCH 2/8] frv: Use __INIT macro instead of .text.init Tim Abbott
2009-04-27 18:02     ` [PATCH 3/8] arm: " Tim Abbott
2009-04-27 18:02       ` [PATCH 4/8] powerpc: Use TEXT_TEXT macro in linker script Tim Abbott
2009-04-27 18:02         ` [PATCH 5/8] powerpc: Use __REF macro instead of old .text.init.refok Tim Abbott
2009-04-27 18:02           ` [PATCH 6/8] sh: Use __INIT macro instead of .text.init Tim Abbott
2009-04-27 18:02             ` [PATCH 7/8] sparc: cleanup references to deprecated .text.init* sections Tim Abbott
2009-04-27 18:02               ` [PATCH 8/8] Remove unused support code for refok sections Tim Abbott
2009-04-27 18:51                 ` Sam Ravnborg
2009-04-27 18:50               ` [PATCH 7/8] sparc: cleanup references to deprecated .text.init* sections Sam Ravnborg
2009-04-27 18:47             ` [PATCH 6/8] sh: Use __INIT macro instead of .text.init Sam Ravnborg
2009-04-27 21:54             ` Paul Mundt
2009-04-27 18:44           ` [PATCH 5/8] powerpc: Use __REF macro instead of old .text.init.refok Sam Ravnborg
2009-04-27 18:44         ` [PATCH 4/8] powerpc: Use TEXT_TEXT macro in linker script Sam Ravnborg
2009-04-27 18:43       ` [PATCH 3/8] arm: Use __INIT macro instead of .text.init Sam Ravnborg
2009-04-27 18:44         ` Russell King
2009-04-27 18:37     ` Sam Ravnborg [this message]
2009-04-27 18:31   ` [PATCH 1/8] frv: Remove unused header asm/init.h Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090427183737.GB12056@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=andersk@MIT.EDU \
    --cc=dhowells@redhat.com \
    --cc=jbarnold@MIT.EDU \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tabbott@MIT.EDU \
    --cc=torvalds@linux-foundation.org \
    --cc=vda.linux@googlemail.com \
    --cc=wdaher@MIT.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®