mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ravikiran G Thirumalai <kiran@scalex86.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: use dmi check in apic_is_clustered with 64bit
Date: Mon, 27 Apr 2009 16:30:47 -0700	[thread overview]
Message-ID: <20090427233047.GB6377@localdomain> (raw)
In-Reply-To: <49F5532A.5000802@kernel.org>

On Sun, Apr 26, 2009 at 11:39:38PM -0700, Yinghai Lu wrote:
>
>will have system with 2 and more sockets 8cores/2thread.
>do treat them as multi chassis.
>
>use dmi check instead.
>
>[ Impact: do not make unstable TSC on wrongly ]
>
>Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>

The patch looks good.
Just one minor observation -- apic_is_clustered_box()
is used only to check if tscs are synced.  It is not used elsewhere. Since
the routine is not actually checking if the box uses clustered apic --
rather the routine is used to determine if tsc's are synced are not, the name
could be changed appropriately I guess?

...
>+}
>+
>+/*
>+ * apic_is_clustered_box() -- Check if we can expect good TSC
>+ *
>+ * Thus far, the major user of this is IBM's Summit2 series:
>+ * Clustered boxes may have un-synced TSC problems if they are
>+ * multi-chassis.
>+ * Use DMI to check them
>+ */
>+__cpuinit int apic_is_clustered_box(void)
>+{
>+	dmi_check_multi();
>+	if (multi)
> 		return 1;
> 
>+	if (!is_vsmp_box())
>+		return 0;
>+
> 	/*
>-	 * If clusters > 2, then should be multi-chassis.
>-	 * May have to revisit this when multi-core + hyperthreaded CPUs come
>-	 * out, but AFAIK this will work even for them.
>+	 * ScaleMP vSMPowered boxes have one cluster per board and TSCs are
>+	 * not guaranteed to be synced between boards
> 	 */
>-	return (clusters > 2);
>+	if (apic_cluster_num() > 1)
>+		return 1;
>+
>+	return 0;
> }

...

      parent reply	other threads:[~2009-04-27 23:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27  6:39 Yinghai Lu
2009-04-27 17:00 ` [tip:x86/apic] x86: Use dmi check in apic_is_clustered() on 64-bit to mark the TSC unstable tip-bot for Yinghai Lu
2009-04-27 23:30 ` Ravikiran G Thirumalai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090427233047.GB6377@localdomain \
    --to=kiran@scalex86.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®