mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
	Grazvydas Ignotas <notasas@gmail.com>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Tony Lindgren <tony@atomide.com>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Paul Walmsley <paul@pwsan.com>,
	Jarkko Lavinen <jarkko.lavinen@nokia.com>,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] make mmci-omap using platform_driver_probe
Date: Tue, 28 Apr 2009 21:27:14 +0200	[thread overview]
Message-ID: <20090428212714.3c9bbc3d@mjolnir.ossman.eu> (raw)
In-Reply-To: <1238694461-29501-1-git-send-email-u.kleine-koenig@pengutronix.de>

On Thu,  2 Apr 2009 19:47:41 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> A pointer to mmc_omap_probe which lives in .init.text is passed to the
> core via platform_driver_register and so the kernel might oops if probe
> is called after the init code is discarded.
> 
> As requested by David Brownell platform_driver_probe is used instead of
> moving the probe function to .devinit.text.  This saves some memory, but
> might have the downside that a device being registered after the call to
> mmc_omap_init but before the init sections are discarded will not be
> bound anymore to the driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Grazvydas Ignotas <notasas@gmail.com>
> Cc: Pierre Ossman <drzeus-mmc@drzeus.cx>
> Cc: David Brownell <dbrownell@users.sourceforge.net>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Jarkko Lavinen <jarkko.lavinen@nokia.com>
> Cc: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> 
> ---

Queued.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org
  TigerVNC, core developer          http://www.tigervnc.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

  parent reply	other threads:[~2009-04-28 19:27 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-27 23:21 [RESENT] platform_driver's probe functions must not be located in .init.text Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 01/58] move acornfb's probe function to .devinit.text Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 02/58] move am79c961's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 03/58] move arcfb's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 04/58] move at91_ether's " Uwe Kleine-König
2009-03-28  0:09   ` David Brownell
2009-03-28  6:32     ` Uwe Kleine-König
2009-03-28 16:27       ` David Brownell
2009-04-02 17:47         ` [PATCH] make mmci-omap using platform_driver_probe Uwe Kleine-König
2009-04-02 17:51           ` Uwe Kleine-König
2009-04-16 20:53           ` David Brownell
2009-04-28 19:27           ` Pierre Ossman [this message]
2009-04-28 22:11             ` David Brownell
2009-03-27 23:26 ` [PATCH 05/58] move at91_wdt's probe function to .devinit.text Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 06/58] move bf54x-lq043's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 07/58] move cfag12864bfb's " Uwe Kleine-König
2009-03-28 18:43   ` Miguel Ojeda
2009-03-27 23:26 ` [PATCH 08/58] move leds-clevo-mail's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 09/58] move cobalt-lcd's " Uwe Kleine-König
2009-03-28 10:43   ` Ralf Baechle
2009-03-27 23:26 ` [PATCH 10/58] move corgi-ssp's " Uwe Kleine-König
2009-03-28  9:31   ` Eric Miao
2009-03-27 23:26 ` [PATCH 11/58] move efifb's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 12/58] move orion-ehci's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 13/58] move epson1355fb's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 14/58] move sh_flctl's " Uwe Kleine-König
2009-03-30  2:26   ` Yoshihiro Shimoda
2009-03-27 23:26 ` [PATCH 15/58] move gbefb's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 16/58] move h1940-bt's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 17/58] move h1940-leds's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 18/58] move hgafb's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 19/58] move hitfb's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 20/58] move hp680-bl's " Uwe Kleine-König
2009-03-28  9:25   ` Kristoffer Ericson
2009-03-27 23:26 ` [PATCH 21/58] move hp-wmi's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 22/58] move jazzsonic's " Uwe Kleine-König
2009-03-28  8:40   ` Geert Uytterhoeven
2009-03-28 10:45   ` Ralf Baechle
2009-03-28 19:25   ` [PATCH] " Uwe Kleine-König
2009-03-29  8:55     ` Geert Uytterhoeven
2009-03-27 23:26 ` [PATCH 23/58] move jornada_ssp's " Uwe Kleine-König
2009-03-28  9:26   ` Kristoffer Ericson
2009-03-27 23:26 ` [PATCH 24/58] move ks8695_wdt's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 25/58] move macsonic's " Uwe Kleine-König
2009-03-28  8:39   ` Geert Uytterhoeven
2009-03-28 19:33   ` [PATCH] " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 26/58] move meth's " Uwe Kleine-König
2009-03-28 10:45   ` Ralf Baechle
2009-03-27 23:26 ` [PATCH 27/58] move mmci-omap's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 28/58] move mailbox's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 29/58] move omap24xxcam's " Uwe Kleine-König
2009-04-01  7:40   ` Sakari Ailus
2009-04-01  8:28     ` Uwe Kleine-König
2009-04-01  9:02       ` Sakari Ailus
2009-04-01  8:36   ` Trilok Soni
2009-03-27 23:26 ` [PATCH 30/58] move mailbox's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 31/58] move omap_hdq's " Uwe Kleine-König
2009-03-28  8:21   ` Evgeniy Polyakov
2009-03-28 19:37     ` Uwe Kleine-König
2009-03-28 20:53       ` Evgeniy Polyakov
2009-03-27 23:26 ` [PATCH 32/58] move i2c_omap's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 33/58] move mmci-omap-hs's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 34/58] move omap_rng's " Uwe Kleine-König
2009-03-29  7:47   ` Herbert Xu
2009-03-29 19:03     ` David Brownell
2009-03-27 23:26 ` [PATCH 35/58] move omap_wdt's " Uwe Kleine-König
2009-03-29 18:09   ` Wim Van Sebroeck
2009-03-29 18:15     ` Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 36/58] move orion_nand's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 37/58] move gen_nand's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 38/58] move q40fb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 39/58] move r8a66597_hcd's " Uwe Kleine-König
2009-03-30  2:26   ` Yoshihiro Shimoda
2009-03-27 23:27 ` [PATCH 40/58] move s3c241xfb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 41/58] move sa11x0-fb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 42/58] move flash's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 43/58] move sb1250-mac's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 44/58] move sgiseeq's " Uwe Kleine-König
2009-03-28 10:45   ` Ralf Baechle
2009-03-27 23:27 ` [PATCH 45/58] move sgivwfb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 46/58] move sgiwd93's " Uwe Kleine-König
2009-03-28 10:46   ` Ralf Baechle
2009-03-27 23:27 ` [PATCH 47/58] move sharpsl-pm's " Uwe Kleine-König
2009-03-28  9:32   ` Eric Miao
2009-03-28 19:38     ` Uwe Kleine-König
2009-03-29  1:23       ` Eric Miao
2009-03-27 23:27 ` [PATCH 48/58] move sh_mobile_lcdc_fb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 49/58] move snd_powermac's " Uwe Kleine-König
2009-04-06  2:09   ` Takashi Iwai
2009-03-27 23:27 ` [PATCH 50/58] move snirm_53c710's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 51/58] move stk17ta8's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 52/58] move twl4030_usb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 53/58] move omap_udc's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 54/58] move vesafb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 55/58] move vfb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 56/58] move vga16fb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 57/58] move w100fb's " Uwe Kleine-König
2009-03-28 10:01   ` pHilipp Zabel
2009-03-28 19:13     ` Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 58/58] move xtsonic's " Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090428212714.3c9bbc3d@mjolnir.ossman.eu \
    --to=drzeus-mmc@drzeus.cx \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=carlos.aguiar@indt.org.br \
    --cc=dbrownell@users.sourceforge.net \
    --cc=jarkko.lavinen@nokia.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=notasas@gmail.com \
    --cc=paul@pwsan.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=tony@atomide.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®