From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764827AbZD3RJx (ORCPT ); Thu, 30 Apr 2009 13:09:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764283AbZD3RHV (ORCPT ); Thu, 30 Apr 2009 13:07:21 -0400 Received: from kroah.org ([198.145.64.141]:56151 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762241AbZD3RHQ (ORCPT ); Thu, 30 Apr 2009 13:07:16 -0400 X-Mailbox-Line: From gregkh@mini.kroah.org Thu Apr 30 09:57:39 2009 Message-Id: <20090430165739.242208431@mini.kroah.org> User-Agent: quilt/0.48-1 Date: Thu, 30 Apr 2009 09:55:55 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , Willy Tarreau , Rodrigo Rubira Branco , Jake Edge , Eugene Teo , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, "David S. Miller" Subject: [patch 06/88] xfrm: spin_lock() should be spin_unlock() in xfrm_state.c References: <20090430165549.117010404@mini.kroah.org> Content-Disposition: inline; filename=xfrm-spin_lock-should-be-spin_unlock-in-xfrm_state.c.patch In-Reply-To: <20090430170122.GA16015@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.28-stable review patch. If anyone has any objections, please let us know. ------------------ From: Chuck Ebbert [ Upstream commit 7d0b591c655ca0d72ebcbd242cf659a20a8995c5 ] spin_lock() should be spin_unlock() in xfrm_state_walk_done(). caused by: commit 12a169e7d8f4b1c95252d8b04ed0f1033ed7cfe2 "ipsec: Put dumpers on the dump list" Reported-by: Marc Milgram Signed-off-by: Chuck Ebbert Signed-off-by: David S. Miller --- net/xfrm/xfrm_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c @@ -1601,7 +1601,7 @@ void xfrm_state_walk_done(struct xfrm_st spin_lock_bh(&xfrm_state_lock); list_del(&walk->all); - spin_lock_bh(&xfrm_state_lock); + spin_unlock_bh(&xfrm_state_lock); } EXPORT_SYMBOL(xfrm_state_walk_done);