From: Joe Korty <joe.korty@ccur.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "venkatesh.pallipadi@intel.com" <venkatesh.pallipadi@intel.com>,
"mingo@elte.hu" <mingo@elte.hu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clear irq pending when bypassing it
Date: Thu, 30 Apr 2009 14:00:12 -0400 [thread overview]
Message-ID: <20090430180011.GB28139@tsunami.ccur.com> (raw)
In-Reply-To: <m11vra13z0.fsf@fess.ebiederm.org>
On Thu, Apr 30, 2009 at 12:49:39PM -0400, Eric W. Biederman wrote:
> Joe Korty <jak@typhoon.ccur.com> writes:
>
> > IRQ_MOVE_PENDING must be cleared whenever it is bypassed.
> >
> > Otherwise, we risk an old, pending affinity change
> > overtaking and erasing a more recent affinity change that
> > had been directly applied (eg, IRQ_MOVE_PCNTXT mode).
>
> When can this happen?
Probably doesn't happen. AFAIK, each IRQ is either fully MSI
or non-MSI. The MSI IRQs will always use IRQ_MOVE_PCNTXT and
the non-MSI's will never use IRQ_MOVE_PCNTXT. Thus no collision.
It could only happen if it was possible for a MSI and non-MSI
device to share an IRQ.
Joe
next prev parent reply other threads:[~2009-04-30 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090430161506.GA2636@typhoon.ccur.com>
2009-04-30 16:49 ` Eric W. Biederman
2009-04-30 18:00 ` Joe Korty [this message]
2009-04-30 18:43 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090430180011.GB28139@tsunami.ccur.com \
--to=joe.korty@ccur.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®