From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptrace: do not use task->ptrace directly in core kernel
Date: Thu, 30 Apr 2009 13:28:28 -0700 (PDT) [thread overview]
Message-ID: <20090430202828.8A763FC3BF@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of Wednesday, 29 April 2009 14:28:27 +0200 <20090429122827.GA27838@redhat.com>
That is fine, but doesn't buy much. i.e., we will be changing these again
before too long anyway I imagine.
I added task_ptrace() just for tracehook.h use, really. There it drives
the event hooks. Those uses are directly obsoleted by using another event
hooking mechanism such as utrace. That applies to ptrace_signal() too.
But the other uses will be replaced by something different later, not just
go away.
The BUG_ON cases might as well just go away, probably.
The exit.c cases might be clearer if we give them a (trivial) local helper
with a more topical name like task_wait_inhibited().
ptrace_fork() is a wrapper that just calls arch_ptrace_fork(), which itself
is an empty macro on most configurations. I think we might as well just
make ptrace_fork() an inline in linux/ptrace.h and put the test inside it.
(Thus any future changes touch ptrace.h and not fork.c.)
Thanks,
Roland
next prev parent reply other threads:[~2009-04-30 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 12:28 Oleg Nesterov
2009-04-30 20:28 ` Roland McGrath [this message]
2009-05-03 19:54 ` Oleg Nesterov
2009-05-04 17:39 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090430202828.8A763FC3BF@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®