mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Tim Abbott <tabbott@MIT.EDU>
Subject: in_suspend and __nosave
Date: Thu, 30 Apr 2009 22:30:00 +0200	[thread overview]
Message-ID: <20090430203000.GA10999@uranus.ravnborg.org> (raw)

Hi Rafael & Linus.

While unifying vmlinux.lds for x86 I stumbled
over the .data.nosave section.

Searching a bit I found only a single user:

swsusp.c:int in_suspend __nosavedata = 0;

Do we really needs all this complexity for this single integer?
We have this section defined in several arch lds files.

I understand that in_suspend is special as in that we do not
want the value restored while resuming.
But is there no other way to do so today?

All I want is to kill a lot from the vmlinux.lds files.

It also occur to me that only: x86, powerpc, and sh
implement pfn_is_nosave() which I think is the only
place where we decide if we want to save a page or not.

But we define the .data.nosave section in following
architectures:
arm, m32r, mips, mn10300, parisc, s390 in addition
to the above archs that define pfn_is_nosave().
Is this something to be cleaned up?

	Sam

             reply	other threads:[~2009-04-30 20:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-30 20:30 Sam Ravnborg [this message]
2009-04-30 22:09 ` Rafael J. Wysocki
2009-05-03 21:57 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090430203000.GA10999@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=tabbott@MIT.EDU \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®