From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758678AbZEADlU (ORCPT ); Thu, 30 Apr 2009 23:41:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755309AbZEADlG (ORCPT ); Thu, 30 Apr 2009 23:41:06 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:50631 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754273AbZEADlE (ORCPT ); Thu, 30 Apr 2009 23:41:04 -0400 Date: Thu, 30 Apr 2009 20:38:37 -0700 From: Andrew Morton To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Frederic Weisbecker Subject: Re: [PATCH 1/3] ring-buffer: add counters for commit overrun and nmi dropped entries Message-Id: <20090430203837.ad058c3d.akpm@linux-foundation.org> In-Reply-To: References: <20090501022210.851418183@goodmis.org> <20090501022400.894326175@goodmis.org> <20090430200034.fb794702.akpm@linux-foundation.org> <20090430202242.aeeb1954.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Apr 2009 23:33:31 -0400 (EDT) Steven Rostedt wrote: > > Should you decide to retire the paste pot, and if you can bear to move > > `struct ring_buffer' into a header, these four functions could be made > > static inlines, with pleasant runtime results. > > Well, the only users of these functions are those that output to user > land. The latency format and the stat file. OK, that's slowpath. They were exported to modules - are these files a per-tracer thing?