From: Oliver Neukum <oliver@neukum.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Guillaume Chazarain <guichaz@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: What's in hid.git for 2.6.30
Date: Fri, 1 May 2009 11:02:18 +0200 [thread overview]
Message-ID: <200905011102.18945.oliver@neukum.org> (raw)
In-Reply-To: <alpine.LNX.2.00.0905010103550.5012@wotan.suse.de>
Am Friday 01 May 2009 01:09:12 schrieben Sie:
> On Fri, 1 May 2009, Oliver Neukum wrote:
> > > --- a/drivers/hid/hid-core.c
> > > +++ b/drivers/hid/hid-core.c
> > > @@ -1824,6 +1824,9 @@ int hid_check_keys_pressed(struct hid_device
> > > *hid) struct hid_input *hidinput;
> > > int i;
> > >
> > > + if (!(hid->claimed & HID_CLAIMED_INPUT))
> > > + return 0;
> > > +
> >
> > is there a guarantee all keyboards will be claimed as input devices?
>
> Hi Oliver,
>
> do you see any way how hid->inputs could currently be initialized other
> than the device being claimed by hid-input?
No, but I am worried about a false return of 0 here, not the other way
round. This method is necessary because keyboards don't wake up
if a key is released. Suspending a keyboard with a key pressed will lead
to an endless repetition of that key.
So I wonder whether it is possible to have a keyboard not claimed as an
input device.
Regards
Oliver
next prev parent reply other threads:[~2009-05-01 9:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 23:07 Jiri Kosina
2009-04-30 22:29 ` Guillaume Chazarain
2009-04-30 22:45 ` Jiri Kosina
2009-04-30 23:02 ` Oliver Neukum
2009-04-30 23:09 ` Jiri Kosina
2009-05-01 9:02 ` Oliver Neukum [this message]
2009-05-01 15:54 ` Jiri Kosina
2009-05-01 16:09 ` Oliver Neukum
2009-05-01 16:16 ` Jiri Kosina
2009-05-01 16:49 ` Oliver Neukum
2009-04-30 23:37 ` Guillaume Chazarain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905011102.18945.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=guichaz@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®