From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753139AbZECJeP (ORCPT ); Sun, 3 May 2009 05:34:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752261AbZECJd6 (ORCPT ); Sun, 3 May 2009 05:33:58 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:34633 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbZECJd5 (ORCPT ); Sun, 3 May 2009 05:33:57 -0400 Date: Sun, 3 May 2009 11:36:59 +0200 From: Pavel Machek To: Linus Torvalds Cc: "Rafael J. Wysocki" , Andrew Morton , jens.axboe@oracle.com, alan-jenkins@tuffmail.co.uk, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, linux-pm@lists.linux-foundation.org Subject: Re: [PATCH 3/4] PM/Hibernate: Use memory allocations to free memory (rev. 2) Message-ID: <20090503093659.GA10278@elf.ucw.cz> References: <20090502104947.2720f173.akpm@linux-foundation.org> <200905030220.57933.rjw@sisk.pl> <200905030224.21471.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > Remove the shrinking of memory from the suspend-to-RAM code, where it is > > not really necessary. > > Hmm. Shouldn't we do this _regardless_? > > IOW, shouldn't this be a totally separate patch? It seems to be left-over > from when we shared the same code-paths, and before the split of the STR > and hibernate code? > > IOW, shouldn't the very _first_ patch just be this part? That code doesn't > make any sense anyway (that FREE_PAGE_NUMBER really _is_ totally > arbitrary). > > This part seems to be totally independent of all the other parts in your > patch-series. No? I'm not sure this one is a good idea: drivers will need to allocate memory during suspend/resume, and when processes are frozen/disk driver is suspended, normal memory management will no longer work. So, freeing 4M of memory before starting suspend seems like a good idea. That way those small alocations will not fail. Pavel > @@ -188,9 +188,6 @@ static void suspend_test_finish(const char *label) > > #endif > > -/* This is just an arbitrary number */ > -#define FREE_PAGE_NUMBER (100) > - > static struct platform_suspend_ops *suspend_ops; > > /** > @@ -241,24 +238,10 @@ static int suspend_prepare(void) > if (error) > goto Finish; > > - if (suspend_freeze_processes()) { > - error = -EAGAIN; > - goto Thaw; > - } > - > - free_pages = global_page_state(NR_FREE_PAGES); > - if (free_pages < FREE_PAGE_NUMBER) { > - pr_debug("PM: free some memory\n"); > - shrink_all_memory(FREE_PAGE_NUMBER - free_pages); > - if (nr_free_pages() < FREE_PAGE_NUMBER) { > - error = -ENOMEM; > - printk(KERN_ERR "PM: No enough memory\n"); > - } > - } > + error = suspend_freeze_processes(); > if (!error) > return 0; > > - Thaw: > suspend_thaw_processes(); > usermodehelper_enable(); > Finish: -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html