From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756081AbZEFHas (ORCPT ); Wed, 6 May 2009 03:30:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752856AbZEFHai (ORCPT ); Wed, 6 May 2009 03:30:38 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:52712 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752381AbZEFHah (ORCPT ); Wed, 6 May 2009 03:30:37 -0400 Date: Wed, 6 May 2009 09:30:25 +0200 From: Ingo Molnar To: Jason Wessel Cc: greg@kroah.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] usb,early_printk: insert cr prior to nl as needed Message-ID: <20090506073025.GB17457@elte.hu> References: <1241575205-12199-1-git-send-email-jason.wessel@windriver.com> <1241575205-12199-2-git-send-email-jason.wessel@windriver.com> <1241575205-12199-3-git-send-email-jason.wessel@windriver.com> <1241575205-12199-4-git-send-email-jason.wessel@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1241575205-12199-4-git-send-email-jason.wessel@windriver.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jason Wessel wrote: > The rs232 drivers send a carriage return prior to a new line in the > early printk code. > > The usb debug driver should do the same because you want to be able to > use the same terminal programs and tools for analysis of early printk > data. > > Signed-off-by: Jason Wessel > --- > arch/x86/kernel/early_printk.c | 22 ++++++++++++++++------ > 1 files changed, 16 insertions(+), 6 deletions(-) hm, would be better to carry this in the x86 tree - where most of the early-debug functionality has been authored and maintained. Greg, is that fine with you? Ingo