mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	oprofile-list <oprofile-list@lists.sourceforge.net>
Subject: Re: [PATCH 0/2] oprofile: introduce module parameter oprofile.cpu_type
Date: Wed, 6 May 2009 16:47:20 +0200	[thread overview]
Message-ID: <20090506144720.GQ23223@one.firstfloor.org> (raw)
In-Reply-To: <1241613554-31539-1-git-send-email-robert.richter@amd.com>

On Wed, May 06, 2009 at 02:39:12PM +0200, Robert Richter wrote:
> The current userland does not yet fully support all cpu types
> implemented in the kernel. With the module parameter oprofile.cpu_type
> a certain cpu type can be reported to the oprofile userland and thus
> makes the kernel usable with current distros.

On Intel systems forcing archperfmon is the only one that makes sense
nd only if the CPU supports arch perfmon(btw that's already in my patchkit
which you haven't commented on so far)

I don't thinking forcing core2 on a system like Nehalem with completely
different events is a good idea though. This just means if the user
selects anything unusual they will get junk data, which is just
a bad design.

Also if you force core2 on a P4 system the kernel will just oops
because it will access MSRs that are not there. So I don't think
that's a good idea.

It means you have to update oprofile userland at least once until
you have arch perfmon support, but I think even Linus will be able
to do that :) Hopefully Maynard will do a new release soon.

The force of core2 is nacked from my side.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  parent reply	other threads:[~2009-05-06 14:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06 12:39 Robert Richter
2009-05-06 12:39 ` [PATCH 1/2] oprofile: introduce module_param oprofile.cpu_type Robert Richter
2009-05-06 12:39 ` [PATCH 2/2] x86/oprofile: add module parameter option to force a core 2 cpu Robert Richter
2009-05-06 14:47 ` Andi Kleen [this message]
2009-05-06 16:39   ` [PATCH 0/2] oprofile: introduce module parameter oprofile.cpu_type Robert Richter
2009-06-10 13:07   ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090506144720.GQ23223@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oprofile-list@lists.sourceforge.net \
    --cc=robert.richter@amd.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®