From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760320AbZEFQvn (ORCPT ); Wed, 6 May 2009 12:51:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751733AbZEFQvc (ORCPT ); Wed, 6 May 2009 12:51:32 -0400 Received: from mx2.redhat.com ([66.187.237.31]:35050 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbZEFQvb (ORCPT ); Wed, 6 May 2009 12:51:31 -0400 Date: Wed, 6 May 2009 09:49:45 -0700 From: Chris Wright To: Hugh Dickins Cc: Izik Eidus , Andrea Arcangeli , Rik van Riel , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, chrisw@redhat.com, alan@lxorguk.ukuu.org.uk, device@lanana.org, linux-mm@kvack.org, nickpiggin@yahoo.com.au Subject: Re: [PATCH 3/6] ksm: change the KSM_REMOVE_MEMORY_REGION ioctl. Message-ID: <20090506164945.GD15712@x200.localdomain> References: <1241475935-21162-1-git-send-email-ieidus@redhat.com> <1241475935-21162-2-git-send-email-ieidus@redhat.com> <1241475935-21162-3-git-send-email-ieidus@redhat.com> <1241475935-21162-4-git-send-email-ieidus@redhat.com> <4A00DF9B.1080501@redhat.com> <4A014C7B.9080702@redhat.com> <20090506133434.GX16078@random.random> <4A019719.7030504@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Hugh Dickins (hugh@veritas.com) wrote: > On Wed, 6 May 2009, Izik Eidus wrote: > > Andrea Arcangeli wrote: > > > On Wed, May 06, 2009 at 12:16:52PM +0100, Hugh Dickins wrote: > > > > > > > > > > p.s. I wish you'd chosen different name than KSM - the kernel > > > > has supported shared memory for many years - and notice ksm.c itself > > > > says "Memory merging driver". "Merge" would indeed have been a less > > > > ambiguous term than "Share", but I think too late to change that now > > > > - except possibly in the MADV_ flag names? > > > > > > > > > > I don't actually care about names, so I leave this to other to discuss. > > > > > Well, There is no real problem changing the name, any suggestions? > > mm/merge.c or mm/mmerge.c: the module formerly known as KSM ? I like merge. For madvise() approach I had used: +#define MADV_SHAREABLE 12 /* can share identical pages */ +#define MADV_UNSHAREABLE 13 /* can not share identical pages But those are maybe better put as MADV_(UN)MERGEABLE (gets a bit confusing when you talk of merging vmas ;-) */ thanks, -chris