From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@gmail.com>, Ferenc Wagner <wferi@niif.hu>
Subject: Re: [PATCH 1/2] Char: rocket, fix ASYNC flags
Date: Fri, 8 May 2009 12:13:06 +0100 [thread overview]
Message-ID: <20090508121306.643f41c3@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1241771564-31133-1-git-send-email-jirislaby@gmail.com>
On Fri, 8 May 2009 10:32:43 +0200
Jiri Slaby <jirislaby@gmail.com> wrote:
> ASYNC_* flags are not bits, but rather constants, use ilog2 to obtain
> bit positions and stay atomic.
Definitely agree with the bug but it would I think be cleaner to add
ASYNCF_.. (or ASYNCB_.. or similar) that is the bit numbers rather than
use ilog2. That also means we can later delete ASYNC_xxx from the kernel
side to stop people using them unsafely in drivers
next prev parent reply other threads:[~2009-05-08 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 0:36 rocket tty BUG in 2.6.29 (regression) Ferenc Wagner
2009-05-08 8:32 ` [PATCH 1/2] Char: rocket, fix ASYNC flags Jiri Slaby
2009-05-08 11:13 ` Alan Cox [this message]
2009-05-08 11:18 ` Jiri Slaby
2009-05-08 8:32 ` [PATCH 2/2] Char: epca, " Jiri Slaby
2009-05-08 10:03 ` rocket tty BUG in 2.6.29 (regression) Alan Cox
2009-05-08 14:33 ` Ferenc Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090508121306.643f41c3@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wferi@niif.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®